feat(github): support job sets as reusable workflows#20
Closed
feat(github): support job sets as reusable workflows#20
Conversation
Jobs inside a reusable workflow cannot reference jobs from other reusable workflows. Strip any cross-job-set needs (and corresponding if conditions) from jobs rendered inside reusable workflow files. Ordering across job-sets is guaranteed at the caller level via the workflow_call job's needs in ci.yaml.
When a job inside a reusable workflow depends on an inline job (not in any reusable job-set), the ordering must be expressed at the caller level. Add those inline dependencies to the workflow_call job's needs list in ci.yaml so GitHub Actions waits for them before starting the reusable workflow.
terlar
force-pushed
the
github-improvements
branch
from
75448d2 to
9eca2c8
Compare
…names When a reusable job-set's needs reference a non-reusable job-set whose jobs all live inside reusable workflows, the caller must depend on those reusable workflow jobs (job-set names), not the individual job names that are now hidden inside reusable workflow files and unknown to ci.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.