fix: update APR calculation to use virtualXtReserve and adjust half l…#31
Merged
Merged
Conversation
Collaborator
EvanWang-TKSpring
commented
May 21, 2026
EvanWang-TKSpring
commented
- Fix the issue of half-liquidation collateral value judgement.
- Fix the issue that TermMaxOrderV2 apr() view function using incorrect on-chain balance but not virtual xt reserve.
🛡️ Immunefi PR ReviewsWe’ve assigned 1 code reviewer(s) to this PR. They’ll begin the review shortly and leave feedback directly in the pull request. This review is based on the current state of your pull request. If you make changes after the review starts, they won’t be reflected here. To ensure the review includes your latest updates, you’ll need to open a new pull request. |
immunefi-magnus
Bot
added
pr-reviews:pending
pr-reviews:in-progress
and removed
pr-reviews:pending
labels
![immunefi-magnus[bot]](https://avatars.githubusercontent.com/in/1208986?s=60&v=4){kind=small}
There was a problem hiding this comment.
The security review for this PR has been completed. No critical security issues were identified. Full details are available here: https://docs.google.com/document/d/14l__KYbhqiSwjLqsuMh7w7oV5FiwwhscxLdYUpaxtgw/edit?tab=t.6e8eu035xxnx
- WAL
immunefi-magnus
Bot
added
pr-reviews:submitted
and removed
pr-reviews:in-progress
labels
EvanWang-TKSpring
force-pushed
the
fix/order_apy&half_calculation
branch
from
eee49a5 to
66f7942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.