fix num of partitions and faiss index file name pattern matching#67
Open
afurkank wants to merge 1 commit into
Open
fix num of partitions and faiss index file name pattern matching#67afurkank wants to merge 1 commit into
afurkank wants to merge 1 commit into
Conversation
… 100 and allow using faiss index files with names matching the pattern "ivfpq*.faiss"
Collaborator
|
lgtm @afurkank. I might not have a chance to test two different faiss files this week but hopefully next week |
Collaborator
|
Hi @afurkank - I'm still planning at looking at this but ECIR 2024 currently a higher priority :-/ |
Author
|
Hi, sorry for closing the pull request. I did not realize that deleting a fork would close this pr. I sent a ticket for restoring the repo so hopefully I can reopen the pull request.
No problem at all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue of number of partitions for the faiss indexing always being 100 and allow using faiss index files with names matching the pattern "ivfpq*.faiss"
Note that when indexing, FAISS may give a warning like this:
WARNING clustering XXX points to YYY centroidsThis happens when the sample being indexed has number of data points smaller or bigger than some number.
Apparently, the number of data points(n) must be in range of some multiples of the number of centroids(k). This warning can be silenced but I suppose the ColBERT repo might need an update for this.
More information can be found here.