JPQ etc#47
Draft
cmacdonald wants to merge 525 commits into
Draft
Conversation
* protected variables * centroids is now a read-only property * removed unpacking since unused (and commented out relevant tests)
Added links to Colab notebook and sample JPQ index.
Added note about standard pyterrier_dr readme.
Agent-Logs-Url: https://github.com/terrierteam/pyterrier_dr/sessions/6d8bb64e-bb26-4172-bc63-8dc97026322a Co-authored-by: cmacdonald <620938+cmacdonald@users.noreply.github.com>
3 tasks
* Fix all ruff issues in jpq module (F401, E401, F541, E713, E402, E741, F403, F405, F811, E731, E701) Agent-Logs-Url: https://github.com/terrierteam/pyterrier_dr/sessions/9a61345a-fe00-41eb-83b1-7ca3f786e057 Co-authored-by: cmacdonald <620938+cmacdonald@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: cmacdonald <620938+cmacdonald@users.noreply.github.com> Co-authored-by: Craig Macdonald <craig.macdonald@glasgow.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR corresponding to changes made for the JPQ reproducibility paper: A Replicability Study of Joint Product Quantisation for Effective Space-Efficient Dense Retrieval (Macdonald, Tonellotto & Shen. SIGIR 2026).
Functionality: