config, server: handle opening ninbot in separate toplevel

[GroobleDierne]

WIP

[GroobleDierne]

Currently working on finishing this

[GroobleDierne]

Still need to test the latest commit on hyprland and rebase everything on master

[GroobleDierne]

Never mind, there are no merge conflicts

[GroobleDierne]

@tesselslate, any idea why the xdg toplevel isn't being properly destroyed? The window is still open, with the background being visible on hyprland

[tesselslate]

This currently crashes on some compositors (at least river) since xdg_surface_set_window_geometry is called with a width and height of 0 when the compositor doesn't have a size it wants the toplevel to be ahead of time. Not sure if Hyprland sends a non-zero size or if it's just because Hyprland seems to be missing the check for invalid window geometry.

In any event, I'm not sure that it's entirely necessary to send this request, I just send it for the main toplevel because the size information was present and I wasn't sure if there would be any consequences for not sending it.

any idea why the xdg toplevel isn't being properly destroyed? The window is still open, with the background being visible on hyprland

You need to either destroy the xdg_toplevel or commit a NULL buffer to the surface to unmap the toplevel, and ninbot_toplevel_close_handler does neither.