-
Notifications
You must be signed in to change notification settings - Fork 1
Add overcommit #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Use this file to configure the Overcommit hooks you wish to use. This will | ||
| # extend the default configuration defined in: | ||
| # https://github.com/brigade/overcommit/blob/master/config/default.yml | ||
| # | ||
| # At the topmost level of this YAML file is a key representing type of hook | ||
| # being run (e.g. pre-commit, commit-msg, etc.). Within each type you can | ||
| # customize each hook, such as whether to only run it on certain files (via | ||
| # `include`), whether to only display output if it fails (via `quiet`), etc. | ||
| # | ||
| # For a complete list of hooks, see: | ||
| # https://github.com/brigade/overcommit/tree/master/lib/overcommit/hook | ||
| # | ||
| # For a complete list of options that you can use to customize hooks, see: | ||
| # https://github.com/brigade/overcommit#configuration | ||
| # | ||
| # Uncomment the following lines to make the configuration take effect. | ||
|
|
||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Enable hooks for CommitMessage Also
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. most of the commit message hooks are enabled by default |
||
| PreCommit: | ||
| RuboCop: | ||
| enabled: true | ||
| on_warn: fail # Treat all warnings as failures | ||
|
|
||
| TrailingWhitespace: | ||
| enabled: true | ||
|
|
||
| RubyLint: | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How is RubyLint and Rubocop different?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ruby-lint primarily focuses on logic related errors such as the use of non-existing variables instead of focusing on semantics (e.g. the amount of characters per line).
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Nimmyjv Do we need to keep both? I felt we just need only ruby-lint |
||
| enabled: true | ||
| command: ['bundle', 'exec', 'ruby-lint'] | ||
|
|
||
|
|
||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please format the yml file :)
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I dint get it.. format means?
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please fix the format of yml file. Remove extra lines, etc |
||
|
|
||
| PostCheckout: | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Nimmyjv What all are the default postcheckout hooks. Can you please comment here? Its good to keep just bare minimum
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. BowerInstall
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Nimmyjv Do we need all this ?
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we remove this check. |
||
| ALL: # Special hook name that customizes all hooks of this type | ||
| quiet: true # Change all post-checkout hooks to only display output on failure | ||
|
|
||
| IndexTags: | ||
| enabled: true # Generate a tags file with `ctags` each time HEAD changes | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nimmyjv Remove the comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nimmyjv Are you still working on this?