Repository navigation
ESM resolve does not ignore calls before quibbledModules are set #116
Description
I think the intention of the following code snipped is to ignore resolve calls until the first module gets "quibbled":
if (!quibbleLoaderState.quibbledModules) {
return resolve()
}Because the quibbleLoaderState.quibbledModules is a (at least) empty Map, the (!quibbleLoaderState.quibbledModules) expression never gets true.
I got memory issues because every imported module will be cached (and quibbled).
Changing the if-clause to if (!quibbleLoaderState.quibbledModules.size) { solves the issue for me.
Is there an other reason, the .size is missing?
Metadata
Metadata
Assignees
Labels
No labels
Activity
rosston commentedon Nov 15, 2024
Does "memory issues" mean a leak and large memory usage? It feels like this could be cause of testdouble/testdouble.js#534.
markusvoelk-zr commentedon Nov 19, 2024
Yes, i think a intended memory leak (ESM loader does not provide a way to cleanup code cache).
But i think quibble quibbles too much modules because of the code mentioned here.
In my memory dumps, i see a lot of (superfluous) dev packages (sinon, chai, ...). I think it is intentional to have the prod-code in the memory dump?
rosston commentedon Oct 2, 2026
Fixed in #122 (albeit in a different way) and released in 0.11.0.