Handle empty file paths in cucumber pull#71
Open
PierrickTassery wants to merge 1 commit into
Open
Conversation
86b4d3b to
d921b39
Compare
d921b39 to
9dea4d4
Compare
DavertMik
reviewed
Jun 8, 2026
| * @param {Set<string>} usedFileNames - File names already reserved for this pull | ||
| * @returns {string} Safe fallback file name | ||
| */ | ||
| fallbackFileName(content, usedFileNames) { |
Contributor
There was a problem hiding this comment.
@DenysKuchma please check if we can come up wiht better implementaton
regexes look fragile, we need to think about it
Contributor
|
Thanks I will ask our developer to review and merge or provide alternative solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This keeps the
pullworkflow from crashing when the API returns an empty file path indata.files.When the file path is empty, the CLI now generates a fallback filename from the Gherkin
Feature:title and writes the file there instead of trying to write the target directory itself.Refs #70.
Why
check-cucumber pullcurrently assumes every key indata.filesis a writable filename. If the API returns an empty key:then
path.join(targetDir, "")resolves to the target directory andfs.writeFileSyncfails with:Changes
This PR intentionally does not try to solve duplicate source-path collisions; that requires an API-side change because missing feature contents are not present in
data.files.Testing
npm testResult: