QVAC-23075 chore: DO NOT MERGE, overlay-validate the 7 fabric consumers against the VisionPsy fabric branch - #3814
Closed
yingying0906 wants to merge 5 commits into
Closed
QVAC-23075 chore: DO NOT MERGE, overlay-validate the 7 fabric consumers against the VisionPsy fabric branch#3814yingying0906 wants to merge 5 commits into
yingying0906 wants to merge 5 commits into
Conversation
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
yingying0906
added
prebuilds
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
…inst VisionPsy
Rollout Phase A for the VisionPsy fabric change. Adds the shared qvac-fabric overlay
port and points every consumer at it, so all 7 build against the fabric branch head
before the tag exists and before anything is published to the registry.
The port is copied from qvac-registry-vcpkg origin/main, which is two files now;
android-vulkan-version.cmake is gone from the registry and is deliberately not
reinstated here. REF is a branch SHA rather than v${VERSION} because the tag does not
exist yet, and the whole overlay dies at the registry publish.
Consumer version>= pins stay at 10069.0.0. The overlay bypasses version resolution
entirely, so only the overlay port's own version matters here; bumping the pins is
Phase B. default-registry.baseline is untouched in all 7, which is the one thing a
rollout PR must never move.
Roster re-derived rather than assumed:
git grep -l "qvac-fabric" origin/main -- "packages/*/vcpkg.json"
classification-ggml is absent because it consumes the published @qvac/fabric npm
package rather than the vcpkg port.
DO NOT MERGE. Validation only.
… fabric head The branch pinned 7a6425a3a, which predates the review round. Fabric is now 8be2131e2, ten commits on, including the OpenCL view readback fix and the preprocessing changes the consumers should be validated against. SHA512 recomputed from the archive of the full SHA, with the method checked by reproducing the old pin's hash exactly.
The fabric branch gained three commits from the second review pass: the zero image_size rejection extended to idefics3, the libmtmd rebuild note in mtmd.h, and the prompt-sequence assertions in tests.sh. Phase A has to validate the consumers against what will actually be tagged, so the overlay follows the head. SHA512 is the sha512 of the GitHub archive tarball for that commit. Method checked by reproducing the previous pin's hash from the same command before replacing it.
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
Was 295226e2d, which predates four fabric commits, two of which change what the consumers build: d85b1f367 formats string_format into the result rather than a vector, and a812964c9 takes the idefics3 overview from the original again. The other two do not affect the library, 4bccd82aa is test-only and aff60f874 touches build-opencl.yml. Phase A validation against the old pin no longer describes the branch, so no run on it counts as evidence. SHA512 recomputed from the archive for the full 40-char ref.
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
Contributor
Mobile integration tests — @qvac/ocr-ggml (Android)Result: passed
|
Contributor
Mobile integration tests — @qvac/ocr-ggml (iOS)Result: passed
|
Contributor
Mobile integration tests — @qvac/model-fit (Android)Result: passed
|
Contributor
Mobile integration tests — @qvac/embed-llamacpp (Android)Result: passed
|
Contributor
Mobile integration tests — @qvac/model-fit (iOS)Result: passed
|
Contributor
Mobile integration tests — @qvac/translation-nmtcpp (Android)Result: passed
|
Contributor
Mobile integration tests — @qvac/translation-nmtcpp (iOS)Result: passed
|
Contributor
Mobile integration tests — @qvac/embed-llamacpp (iOS)Result: passed
|
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
Contributor
Mobile integration tests — @qvac/vla-ggml (iOS)Result: passed
|
Contributor
Mobile integration tests — @qvac/vla-ggml (Android)Result: passed
|
Fabric head moved with the load-time bounds on the idefics3-style preprocessing metadata, so the 7 consumers need re-validating against it. SHA512 recomputed from the tarball for the new REF. Also drops the em-dashes from the portfile comments and message() strings.
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
Contributor
Mobile integration tests — @qvac/llm-llamacpp (iOS)Result: failed
|
Contributor
Mobile integration tests — @qvac/llm-llamacpp (Android)Result: passed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Validation branch for QVAC-23075 rollout Phase A. It carries a temporary vcpkg overlay that pins
qvac-fabricto a branch SHA,a812964c93ce692e70fc190857614ef462c43850onfeat/QVAC-23075-visionpsy, because the tag does not exist yet. Merging this would point every consumer at an unpublished commit. The overlay dies at the registry publish in Phase B, which replaces it with the real tag.🎯 What problem does this PR solve?
📝 How does it solve it?
vcpkg-overlays/ports/qvac-fabric/and"overlay-ports": ["../../vcpkg-overlays/ports"]to all 7 fabric consumers: embed-llamacpp, fabric, llm-llamacpp, model-fit, ocr-ggml, translation-nmtcpp, vla-ggml.version>=pin is bumped anddefault-registry.baselineis untouched, both of which belong to Phase B.vcpkg-configuration.jsonis edited, and everyon-pr-*workflow watches its own package directory.prebuilds,run-cpp-addon-tests,run-desktop-addon-tests,run-mobile-addon-tests,run-coload-tests. Without them only the light checks run.🧪 How was it tested?
merge-guardis expected to fail here, since this branch is never merged.qvac-test-addon-mobileclone, which is aPAT_TOKENproblem raised with devops and not a code issue.