QVAC-22630 chore: bump model-fit to 0.2.1 and record the fit-context fix - #3917
Merged
Conversation
The unresolved-fit-context fix (#3890) merged before the model-fit-v0.2.0 tag was cut, so it shipped inside published 0.2.0 while that changelog entry documented only the qvac-fabric 10069.1.0 bump. Patch-bump to 0.2.1 and write the entry the fix should have had. No source change — CHANGELOG.md and the package version only.
Contributor
Review StatusCurrent Status: ✅ APPROVED |
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
gianni-cor
approved these changes
Aug 18, 2026
lauripiisang
approved these changes
Aug 18, 2026
opaninakuffo
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
@qvac/model-fit0.2.0 shipped the unresolved-fit-context fix from #3890 withoutdocumenting it.
The ordering is what hid it: #3890 merged at 08:20, #3725 bumped the package to
0.2.0at 11:06 as part of theqvac-fabric10069.1.0 rollout, and npm published0.2.0at 11:39. Themodel-fit-v0.2.0tag points at917db3ce4, which contains#3890's merge commit
02fcd711f— so the code is in the published tarball, whilethe
[0.2.0]changelog entry mentions only the fabric bump. Anyone reading thechangelog to find out when a zero-context
SUCCESSstopped being possible findsnothing.
📝 How does it solve it?
Patch-bumps to
0.2.1and writes the entry the fix should have had, describingthe merged code:
detail::finalizeFitContextreclassifies a successful fit whose context couldnot be resolved — fitted
nCtxof 0 with no trained-context GGUF metadata — asERROR/model-unreadable, instead of returning aSUCCESScarryingnCtx: 0that a caller cannot replay.parseFitProcessResponserejects acompletedresponse withstatus: 0and anon-positive
nCtx, as defence in depth behind the native fix.This release carries no source change. Because the fix already shipped inside
0.2.0, the diff isCHANGELOG.mdplus theversionfield and nothing else, andboth the changelog entry and the commit body say so rather than letting
0.2.1read as a new fix. The alternative was to append the block to the existing
[0.2.0]entry — addons get a git tag and no GitHub Release body, so nothingpublished would have been contradicted — but a released version's notes are a
poor place to grow new content, and a dedicated entry leaves the ordering legible.
🧪 How was it tested?
## [0.2.1]matches the extractor's own regex at.github/actions/verify-changelog-notes/action.yml(
$0 ~ "^## \\[" version "\\]"), and the section body is non-empty up to thenext
^## [.package.jsonversion equals the heading version exactly.git diff --stat origin/mainshows exactly two files;git diff --checkisclean.
0.2.0confirmed as the current npmlatest, so0.2.1is a real forwardbump and not a re-publish.
vcpkg.jsonand
vcpkg-configuration.jsonare deliberately untouched.None. Version metadata and documentation only.