QVAC-23904 chore[bc]: remove the retired onnx addon from the monorepo - #4012
Open
RamazTs wants to merge 4 commits into
Open
QVAC-23904 chore[bc]: remove the retired onnx addon from the monorepo#4012RamazTs wants to merge 4 commits into
RamazTs wants to merge 4 commits into
Conversation
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead. |
Contributor
Workflow security (shadow mode)zizmor found 1080 finding(s) in Findings are annotated inline on the changed files and listed in the job summary. Reproduce locally: pipx run zizmor==1.27.0 --offline .github/ |
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
ishanvohra2
approved these changes
Aug 25, 2026
5 tasks
GustavoA1604
requested changes
Aug 25, 2026
| `ocr-onnx`), which are out of scope for this effort. The in-scope addons are | ||
| declares `"addon": true`. The ONNX Runtime addons that were originally carved | ||
| out of this effort (`onnx`, `ocr-onnx`) have since been removed from the | ||
| monorepo, so no exception remains. The in-scope addons are |
Contributor
There was a problem hiding this comment.
Can just remove the stale references
| pattern. See [INTEGRATION.md](./INTEGRATION.md) for the consumer guide. | ||
| It follows the npm + `prebuilds/` + `include_bare_module(... PREBUILD)` + | ||
| companion-`.bare` pattern that the retired `@qvac/onnx` shared addon | ||
| established. See [INTEGRATION.md](./INTEGRATION.md) for the consumer guide. |
Contributor
There was a problem hiding this comment.
Can just remove the references for retired packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
@qvac/onnxwas the shared ONNX Runtime host: a prebuilt.baremodule several addons linked against so the runtime was built once and loaded once per process. It has no consumers left.ocr-onnxandtts-onnxwere deleted in earlier tickets, and parakeet dropped its@qvac/onnxpeer dependency when it moved to GGML. Nopackage.json,CMakeLists.txtor*.cmakein the monorepo declares@qvac/onnx, linksqvac-onnx, or callsonnx_addon::any more.📝 How does it solve it?
packages/onnx/— addon binding,src/qvac-onnx/headers, 10 C++ test files plus.onnxfixtures,CMakeLists.txt,symbols.map/exports.txt, vcpkg manifests and override triplets, README/INTEGRATION/CHANGELOG/release notes.docs/repository-layout.md.docs/architecture/ADDON-FUZZING.md— onlypackages/translation-nmtcppstill routesre2to the Microsoft registry, and the "except the ONNX Runtime addons (onnx,ocr-onnx)" scope carve-out is dropped, since neither package exists to except any more;packages/fabric/README.md— drops the now-dead../onnxrelative link while keeping the note that fabric reuses that packaging model;onnx,tts-onnx,transcription-parakeet); those release-only settings now live in the sharedvcpkg-overlays/triplets/.@qvac/onnx(packages/fabric,asr-ggml/docs/PARAKEET-CHANGELOG.md), and the ADDON-FUZZING notes about the registry'sonnxruntime-pinned Abseil port, which lives inqvac-registry-vcpkgand is unaffected by this removal.All CI unwiring — the merge-guard paths-filter key,
PREBUILD_KEYS, the ci-router enumeration, the four workflows — is in #4017.🧪 How was it tested?
@qvac/onnx,packages/onnx,qvac-onnxandonnx_addon(excludingnode_modules): the only remaining hits are the intentionally-preserved historical changelog/release-note lines.package.json,CMakeLists.txtand*.cmakefor@qvac/onnx/qvac-onnx/onnxruntime— all matches were insidepackages/onnxitself.main; the failures visible before that are the base-branch onnx pipeline running against a deleted directory, not defects in this diff.💥 Breaking Changes
Breaking for any out-of-tree consumer that installed
@qvac/onnx(public npmlatestis0.15.1) or linked itsqvac-onnxCMake config. Nothing inside the monorepo is affected — there is no in-repo migration path because there is no in-repo consumer; addons needing a shared native runtime now use@qvac/fabric, which follows the same packaging pattern.Follow-up
npm deprecate @qvac/onnxon the published0.15.1(and the GPR dev/feature/tmp tags) once this lands, mirroring the ocr-onnx retirement.packages/asr-ggml/vcpkg/triplets/),docs/repository-layout.mdstill liststranscription-parakeet, andADDON-FUZZING.md's addon inventory still liststranscription-parakeet— none of those directories are tracked any more.