fix[notask]: align SDK @qvac/inference range to the 0.18 line - #4021
Merged
Conversation
Contributor
Review StatusCurrent Status: ✅ APPROVED |
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
- sdk pinned @qvac/inference to ^0.17.0, which resolves to 0.17.1 (<0.18.0) - inference@0.17.1 declares peerOptional @qvac/asr-ggml@^0.1.0, but the SDK depends on @qvac/asr-ggml@^0.3.0, so a consumer install fails with ERESOLVE - inference@0.18.x aligns its addon peers with the SDK's ranges - bump to ^0.18.0 so the resolved inference matches the addon versions
lauripiisang
changed the title
lauripiisang
force-pushed
the
fix/sdk-inference-dep-range
branch
from
August 24, 2026 12:32
d5d7aa2 to
1e16660
Compare
lauripiisang
changed the title
Contributor
Workflow security (shadow mode)zizmor found 1096 finding(s) in Findings are annotated inline on the changed files and listed in the job summary. Reproduce locally: pipx run zizmor==1.27.0 --offline .github/ |
lauripiisang
force-pushed
the
fix/sdk-inference-dep-range
branch
from
August 24, 2026 13:06
2832149 to
1e16660
Compare
lauripiisang
changed the title
opaninakuffo
approved these changes
Aug 24, 2026
Victor-Rodzko
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
Installing
@qvac/sdkfails withERESOLVE(theSDK Pod Checksconsumer-install gate goes red).@qvac/sdkpins@qvac/inferenceto^0.17.0, which resolves to0.17.1— whosepeerOptional @qvac/asr-ggml@^0.1.0conflicts with the SDK's@qvac/asr-ggml@^0.3.0.@qvac/sdk@0.18.1predates the inference split and carries no@qvac/inferencedep, so consumers today are unaffected — the break is latent and would ship on the next publish. The SDK Pod gate already catches it.📝 How does it solve it?
@qvac/inference^0.17.0→^0.18.0inpackages/sdk.0.18.xaligns its addon peer ranges with the SDK's (@qvac/asr-ggml@^0.3.0, etc.), so the resolved inference and the addon versions agree.🧪 How was it tested?
ERESOLVEwith@qvac/asr-ggml@^0.3.0+@qvac/inference@^0.17.0; confirmed+ ^0.18.0resolves cleanly (148 packages, no peer conflict).Scope note — this does NOT fully green main
This PR fixes only the peer-resolution (
ERESOLVE). The SDK build is separately red because main's SDK consumes engine API (VideoClientParams.reference_images) that exists in no installable@qvac/inference— the published0.18.1lacks it. That cannot be fixed by a CI/dependency change without shipping a build whose declared inference dependency can't satisfy its code. This will be fixed separately.