QVAC-23467 infra: skip publish-sdk compile on pull_request_target - #4024
Draft
opaninakuffo wants to merge 1 commit into
Draft
QVAC-23467 infra: skip publish-sdk compile on pull_request_target#4024opaninakuffo wants to merge 1 commit into
opaninakuffo wants to merge 1 commit into
Conversation
The PR path checks out base.sha and typechecks against npm @qvac/inference, which cannot compile main's workspace-linked SDK source. Lockstep verify stays.
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
Contributor
Workflow security (shadow mode)zizmor found 1096 finding(s) in Findings are annotated inline on the changed files and listed in the job summary. Reproduce locally: pipx run zizmor==1.27.0 --offline .github/ |
opaninakuffo
marked this pull request as draft
August 24, 2026 12:53
BrunoCampana
requested review from
Victor-Rodzko
and removed request for
Victor-Rodzko
August 24, 2026 19:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
publish-sdk.ymlruns onpull_request_targetand checks out base.sha (main), thenbun install+bun run buildtypecheck@qvac/sdkagainst npm@qvac/inference. Main's SDK source already uses types that published inference does not export, so the job is red on any PR that touchespackages/sdk/**,packages/inference/**,packages/bare-sdk/**, orpackages/sdk-python/**.pull_request_targetalways uses the YAML frommain.📝 How does it solve it?
pull_request_target, keep checkout + lockstep version verify. Skip bun install/compile/artifact upload inbuild, and skipbuild-bare-sdk/build-inference(they need the skipped dist).workflow_dispatchstill compile and publish as before.🧪 How was it tested?
publish-sdk.ymlpath filters, so the broken compile job should not run here.pull_request_targetpicks up this workflow frommain;Build and Publish QVAC SDK / buildshould pass on lockstep verify alone.