QVAC-24079 fix: raise inactivity timeout in audio-decoder long-WAV test to stop CI flake - #4025
Merged
Merged
Conversation
…CI flake The real-decode test used inactivityTimeoutMs: 100, but decoder-audio's FFmpegDecoder buffers the whole input file before decoding it in one synchronous burst, so the only window where the inactivity timer can fire is during that initial async read. 100ms wasn't enough margin for that read on a loaded CI runner, unrelated to the file's length. QVAC-24079
Contributor
Review StatusCurrent Status: ✅ APPROVED |
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
Victor-Rodzko
had a problem deploying
to
release
August 24, 2026 12:51 — with
GitHub Actions
Failure
Victor-Rodzko
had a problem deploying
to
release
August 24, 2026 12:53 — with
GitHub Actions
Failure
Victor-Rodzko
had a problem deploying
to
release
August 24, 2026 13:03 — with
GitHub Actions
Failure
opaninakuffo
approved these changes
Aug 25, 2026
arun-mani-j
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
@qvac/inference'stest:baresuite intermittently fails "SDK Pod Checks" CI withError: Audio decoding produced no output for 100ms, reported flaky by @opanin.📝 How does it solve it?
@qvac/decoder-audioFFmpegDecoderwithinactivityTimeoutMs: 100. That decoder buffers the entire input file (async read) before decoding it in one uninterrupted synchronous burst — every output chunk lands in the same JS tick, so there's no real gap between chunks once decoding starts.inactivityTimeoutMsfor this one test to5000ms, giving headroom for CI I/O jitter while staying far below the old fixed 10s total-decode cap the test was written to validate against. The other three tests in the file use a fully mocked decoder response and were never at risk.🧪 How was it tested?
npm run testfor@qvac/inference: 1430/1430 tests pass.[inference] test:bare: all passed (flake is rare; confirmed root cause via temporary local timing instrumentation instead, since removed).[inference] test:barepassed in both "SDK Pod Checks" runs, with the previously-flaky test itself completing in 593ms (well under the new 5000ms window):