QVAC-24089 test[skiplog]: skip redundant CosyVoice3 e2e tests on mobile - #4030
Merged
Conversation
Contributor
Review StatusCurrent Status: ✅ APPROVED |
Victor-Rodzko
had a problem deploying
to
release
August 24, 2026 16:04 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Victor-Rodzko
marked this pull request as draft
August 24, 2026 16:05
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
Victor-Rodzko
added
the
test-e2e-full
Victor-Rodzko
force-pushed
the
test/qvac-24089-skip-cosyvoice3-mobile
branch
from
August 25, 2026 08:34
86a4a70 to
bdc342c
Compare
- all 7 tts-cosyvoice3-* e2e tests ran on both mobile platforms; several are slow on Device Farm (emotion-conditioning timed out at 360s, native-streaming and duplex-streaming at 180s in the last full mobile run) and overlap coverage already provided by other TTS tests - keep tts-cosyvoice3-default and tts-cosyvoice3-invalid-emotion on mobile; mark the other five as expected skips via the existing skipTests helper - desktop/Electron coverage for the skipped tests is unchanged Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Victor-Rodzko
force-pushed
the
test/qvac-24089-skip-cosyvoice3-mobile
branch
from
August 25, 2026 09:57
bdc342c to
8c377ff
Compare
Victor-Rodzko
had a problem deploying
to
release
August 25, 2026 10:13 — with
GitHub Actions
Failure
GitHub Actions
Failure
Victor-Rodzko
marked this pull request as ready for review
August 25, 2026 12:40
- the harness derives its per-test timeout from estimatedDurationMs as max(estimate * 2, 120s), so a 60s estimate capped this test at 120s - CosyVoice3 has no GPU path on Mali, so it synthesises on CPU on the Android Device Farm Pixel 9 Pro; the test measured 114015ms there (pass, run 32718078677) and over 120s (timeout, runs 32827063693 and 32834986175) — it was sitting on its own cap and flipping run to run - raise the estimate to 150s so the cap becomes 300s, ~2.5x the observed time - iOS (Metal, 25s) and Adreno Android (~30s) are well inside either bound Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Victor-Rodzko
force-pushed
the
test/qvac-24089-skip-cosyvoice3-mobile
branch
from
August 25, 2026 12:41
ba10a18 to
faadb0f
Compare
arun-mani-j
approved these changes
Aug 25, 2026
opaninakuffo
approved these changes
Aug 25, 2026
Victor-Rodzko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
tts-cosyvoice3-*e2e tests run on both mobile platforms (Android + iOS), but several are very slow on Device Farm. In the last full mobile run, 4 of them timed out:emotion-conditioning(360s),native-streaming(180s),duplex-streaming(180s),default(120s).📝 How does it solve it?
tts-cosyvoice3-default(happy path) andtts-cosyvoice3-invalid-emotion(error path).skipTestshelper, alongside the other mobile-only exclusions inpackages/sdk/e2e/tests/mobile/consumer.ts:tts-cosyvoice3-emotion-conditioningtts-cosyvoice3-streamingtts-cosyvoice3-native-streamingtts-cosyvoice3-sentence-streamingtts-cosyvoice3-duplex-streamingPlatform.OS-gated) since the reasoning applies equally to Android and iOS.🧪 How was it tested?
packages/sdk/e2e/tests/tts-tests.tsexactly, so each resolves to a real test rather than silently matching nothing.