Skip to content

fix[notask]: assemble CLI workspace SDK against local inference - #4035

Closed
opaninakuffo wants to merge 1 commit into
tetherto:mainfrom
opaninakuffo:fix/cli-workspace-local-inference
Closed

fix[notask]: assemble CLI workspace SDK against local inference#4035
opaninakuffo wants to merge 1 commit into
tetherto:mainfrom
opaninakuffo:fix/cli-workspace-local-inference

Conversation

@opaninakuffo

@opaninakuffo opaninakuffo commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • CLI PRs into main run SDK Pod Checks against the in-repo SDK so unreleased SDK APIs can land before an npm publish.
  • That workspace leg npm installed packages/sdk as a store package, which pulled published @qvac/inference. Lab addon pins on main (e.g. @qvac/diffusion-cpp@^0.20.0) then ERESOLVE against the published engine's older peerOptional ranges. CLI-only PRs (including version backmerges) could not merge.

📝 How does it solve it?

  • Reuse packages/sdk/scripts/link-workspace-inference.ts (already used by SDK's own workspace source) so the CLI garage assemble pins @qvac/inference to file:../inference before tsc.
  • Skip-compile still skips only tsc; the helper always runs so a later npm install ../sdk does not re-fetch store inference.
  • Drop the bare-events@^2.8.0 --no-save npm workaround. That existed because npm hoisted untyped 2.4.2. The helper bun installs the SDK, which already hoists typed bare-events (>=2.8.0), same as SDK CI.

🧪 How was it tested?

  • Confirmed the failing job was [cli] sdk-source [workspace] with peerOptional @qvac/diffusion-cpp@"^0.17.0" from published @qvac/inference@0.18.1 vs found 0.20.0.
  • After merge: SDK Pod Checks on a CLI-touching PR should get past that install (no ERESOLVE) and tsc the local SDK.
  • Committed @qvac/sdk range in packages/cli/package.json is unchanged.

Reuse the SDK helper so the garage install pins file:../inference instead of pulling published inference.
@github-actions

Copy link
Copy Markdown
Contributor

Review Status

Current Status: ❌ PENDING
Approvals so far: none

Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member.

@opaninakuffo

Copy link
Copy Markdown
Contributor Author

Replaced by same-repo PR #4043 (tetherto/qvac branch fix/cli-workspace-local-inference). Closing this fork PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant