fix[notask]: assemble CLI workspace SDK against local inference - #4035
Closed
opaninakuffo wants to merge 1 commit into
Closed
fix[notask]: assemble CLI workspace SDK against local inference#4035opaninakuffo wants to merge 1 commit into
opaninakuffo wants to merge 1 commit into
Conversation
Reuse the SDK helper so the garage install pins file:../inference instead of pulling published inference.
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
Contributor
Author
|
Replaced by same-repo PR #4043 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
mainrun SDK Pod Checks against the in-repo SDK so unreleased SDK APIs can land before an npm publish.npm installedpackages/sdkas a store package, which pulled published@qvac/inference. Lab addon pins onmain(e.g.@qvac/diffusion-cpp@^0.20.0) then ERESOLVE against the published engine's older peerOptional ranges. CLI-only PRs (including version backmerges) could not merge.📝 How does it solve it?
packages/sdk/scripts/link-workspace-inference.ts(already used by SDK's own workspace source) so the CLI garage assemble pins@qvac/inferencetofile:../inferencebeforetsc.tsc; the helper always runs so a laternpm install ../sdkdoes not re-fetch store inference.bare-events@^2.8.0 --no-savenpm workaround. That existed because npm hoisted untyped2.4.2. The helperbun installs the SDK, which already hoists typedbare-events(>=2.8.0), same as SDK CI.🧪 How was it tested?
[cli] sdk-source [workspace]withpeerOptional @qvac/diffusion-cpp@"^0.17.0"from published@qvac/inference@0.18.1vs found0.20.0.tscthe local SDK.@qvac/sdkrange inpackages/cli/package.jsonis unchanged.