QVAC-24108 chore: enforce inference's peer dependencies in SDK - #4037
Open
arun-mani-j wants to merge 2 commits into
Open
QVAC-24108 chore: enforce inference's peer dependencies in SDK#4037arun-mani-j wants to merge 2 commits into
arun-mani-j wants to merge 2 commits into
Conversation
Contributor
Review StatusCurrent Status: ✅ APPROVED |
arun-mani-j
force-pushed
the
arun-mani-j/syncAddonsVersion
branch
from
August 25, 2026 07:54
028297d to
b779e8b
Compare
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
arun-mani-j
force-pushed
the
arun-mani-j/syncAddonsVersion
branch
from
August 25, 2026 10:58
b779e8b to
2f706d9
Compare
arun-mani-j
force-pushed
the
arun-mani-j/syncAddonsVersion
branch
from
August 25, 2026 12:05
2f706d9 to
a550a59
Compare
opaninakuffo
previously approved these changes
Aug 25, 2026
arun-mani-j
force-pushed
the
arun-mani-j/syncAddonsVersion
branch
2 times, most recently
from
August 26, 2026 06:29
b75ac09 to
4a49724
Compare
lauripiisang
approved these changes
Aug 26, 2026
arun-mani-j
force-pushed
the
arun-mani-j/syncAddonsVersion
branch
from
August 26, 2026 09:30
4a49724 to
76a088a
Compare
opaninakuffo
approved these changes
Aug 26, 2026
Signed-off-by: Arun Mani J <j.arunmani@proton.me>
Signed-off-by: Arun Mani J <j.arunmani@proton.me>
arun-mani-j
force-pushed
the
arun-mani-j/syncAddonsVersion
branch
from
August 26, 2026 09:50
76a088a to
8e611dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
@qvac/inferencepeerDependencies(optional peers),@qvac/inferencedevDependencies, and@qvac/sdkdependencies. Optional peers do not install transitively, so the SDK hard-depends on the same addons; inference mirrors them intodevDependenciesto build and test against them.📝 How does it solve it?
@qvac/inferencepeerDependenciesis the single source of truth for addon ranges.packages/sdk/scripts/check-addon-ranges.tsfails when any addon's range in@qvac/sdkdependenciesor@qvac/inferencedevDependenciesdiffers from the peer. It reports one line per addon and is silent on success. Example:lintgate (npm run check:addon-ranges), sopr-checks-sdk-podruns it; the pod config'sdepends_on: packages/inferenceruns it on inference-only PRs too.package.jsonfiles directly and has no dependencies.🧪 How was it tested?
peerDependenciesbut absent from the mirrors.lint(eslint + the check),typecheck,format, and the fullpr-checks-sdk-podgate pass.