QVAC-20631 chore: DO NOT MERGE, overlay-validate the 7 fabric consumers against qvac-fabric 10297.1.0 - #4100
Draft
iancris wants to merge 2 commits into
Draft
QVAC-20631 chore: DO NOT MERGE, overlay-validate the 7 fabric consumers against qvac-fabric 10297.1.0#4100iancris wants to merge 2 commits into
iancris wants to merge 2 commits into
Conversation
DO NOT MERGE. Rollout Phase A validation branch for qvac-fabric 10297.1.0. Adds the shared qvac-fabric overlay port pinned at the temp-10297 head (29db2fb9f, "Merge pull request #210 from tetherto/mtp_drafter — RPC: More TP improvments") and points all 7 consumers at it, so they build against the merged fabric commit before the v10297.1.0 tag exists and before anything is published to the registry. Consumer version>= pins are untouched at 10297.0.0 — the overlay bypasses version resolution entirely, so only the overlay port's own version matters here; bumping the pins is Phase B. default-registry.baseline is untouched in all 7. Rollout-Overlay: qvac-fabric 10297.1.0 ref=29db2fb9fd0aab52590926922b66da6edea7c340 sha=29db2fb9fd0aab52590926922b66da6edea7c340
DO NOT MERGE. Rollout Phase A validation branch for qvac-fabric 10297.1.0. Moves the shared qvac-fabric overlay port from the temp-10297 branch head (29db2fb9f) to the head of fabric PR #214 (b098a1f05, "QVAC-24112 fit: budget against real memory availability"), so the 7 consumers build against the fit change before it is merged and before the v10297.1.0 tag exists. PR #214 is 5 commits ahead of, and 0 behind, temp-10297. It touches ggml/include/ggml-backend.h, common/fit.cpp and common/fit.h — public API surface every consumer compiles against, and the budgeting API @qvac/model-fit is named for — so the previous pin at the branch head never exercised any of it. Consumer version>= pins are untouched at 10297.0.0 — the overlay bypasses version resolution entirely, so only the overlay port's own version matters here; bumping the pins is Phase B. default-registry.baseline is untouched in all 7. The overlay port's own version stays 10297.1.0. Re-pinning changes the fabric every consumer builds against, so all 7 are re-dispatched. The greens recorded against the 29db2fb9f pin no longer apply and must not be read as validating this ref. Rollout-Overlay: qvac-fabric 10297.1.0 ref=b098a1f0508356bbfd97c8ba761ebcdcdce682e2 sha=b098a1f0508356bbfd97c8ba761ebcdcdce682e2
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Validation branch for the qvac-fabric
10297.1.0rollout, Phase A. It carries a temporary vcpkg overlay that pinsqvac-fabricto commitb098a1f0508356bbfd97c8ba761ebcdcdce682e2— the head of fabric PR tetherto/qvac-fabric-llm.cpp#214, "QVAC-24112 fit: budget against real memory availability".Merging this would point every consumer at a temporary overlay. The overlay is validation scaffolding only and must be removed in Phase B, after the registry port is published and the tag
v10297.1.0exists.What problem does this PR solve?
The 7 fabric consumers need to be validated against the fabric commit that will become
10297.1.0before the consumer dependency floors are bumped.The overlay on this branch previously pinned the
temp-10297branch head (29db2fb9f). Fabric PR #214 is 5 commits ahead of, and 0 behind,temp-10297and is not yet merged, so that pin never exercised it. #214 changes API surface the consumers compile against:ggml/include/ggml-backend.h— public headercommon/fit.cpp,common/fit.h— the budgeting API@qvac/model-fitis named forggml/src/ggml-cpu/ggml-cpu.cpp,ggml/src/ggml-metal/ggml-metal-device.m,ggml/src/ggml-metal/ggml-metal.cppHow does it solve it?
vcpkg-overlays/ports/qvac-fabric/, pinned by commit SHA (not a tag —v10297.1.0does not exist yet)."overlay-ports": ["../../vcpkg-overlays/ports"]to all 7 fabric consumers:embed-llamacppfabricllm-llamacppmodel-fitocr-ggmltranslation-nmtcppvla-ggmlversion>=pins untouched at10297.0.0. The overlay bypasses version resolution entirely, so only the overlay port's own version matters here; bumping the pins is Phase B.default-registry.baselineuntouched in all 7.@qvac/classification-ggmlis deliberately not included — it dropped theqvac-fabricvcpkg dependency and consumes the published npm package instead.Tested
shasum -a 512over the/archive/tarball vcpkg actually fetches (37,446,085 bytes,gzip -tclean). Worth confirming withvcpkg hashbefore final handoff, asvcpkgwas not available in the authoring environment.on-pr-<consumer>.ymlworkflow files confirmed present on this ref.Notes for reviewers
cpp-lintfailures that are not this change. Re-pinning the overlay changes theqvac-fabricport's vcpkg ABI hash, soqvac-fabricis a guaranteed cache miss and gets compiled from source on every consumer. Compiling any port from source on theqvac-ubuntu2204-x64pool currently trips a libc++/clang version mismatch in the runner image — tracked as QVAC-24201. The signature is"Libc++ only supports Clang 20 and later"followed byerror: "remove_reference not implemented!". That is environmental, not fabric.windowsjob. If its head moves, this overlay must be re-pinned and all 7 consumers re-run.29db2fb9fpin do not carry over — they validated a fabric that did not contain the fit change.