json interpolator - #424
Open
a-khakimov wants to merge 1 commit into
Open
a-khakimov wants to merge 1 commit into
a-khakimov wants to merge 1 commit into
Conversation
dos65
reviewed
Jul 13, 2026
dos65
left a comment
dos65
left a comment
Collaborator
There was a problem hiding this comment.
Извиняюсь за долгое ревью.
Спасибо за фичу. Отличный пр.
Единственное, думаю было бы классно еще чтобы интерполятор внутри строк в жсоне работал, но это можно в ишью отдельные будет потом закинуть
Я чутка комментов оставил минорных
| ) | ||
| } | ||
|
|
||
| val argTrees: List[Tree] = args.iterator.map(_.tree).toList |
Collaborator
There was a problem hiding this comment.
Suggested change
| val argTrees: List[Tree] = args.iterator.map(_.tree).toList | |
| val argTrees: List[Tree] = args.map(_.tree).toList |
| } | ||
|
|
||
| val positionByIndex: Map[Int, HolePosition] = | ||
| holes.iterator.map(h => h.index -> h.position).toMap |
Collaborator
There was a problem hiding this comment.
Suggested change
| holes.iterator.map(h => h.index -> h.position).toMap | |
| holes.map(h => h.index -> h.position).toMap |
| holes.iterator.map(h => h.index -> h.position).toMap | ||
|
|
||
| def renderValue(arg: Tree): Tree = { | ||
| val tpe = c.typecheck(arg.duplicate, silent = false).tpe.widen |
Collaborator
There was a problem hiding this comment.
а есть какая-то причина тут звать тайпчек, а не arg.tpe ?
| ) | ||
|
|
||
| val positionByIndex: Map[Int, HolePosition] = | ||
| holes.iterator.map(h => h.index -> h.position).toMap |
Collaborator
There was a problem hiding this comment.
Suggested change
| holes.iterator.map(h => h.index -> h.position).toMap | |
| holes.map(h => h.index -> h.position).toMap |
|
|
||
| def findHoleInString(parts: List[String]): Int = { | ||
| var i = 0 | ||
| while (i < parts.length - 1) { |
Collaborator
There was a problem hiding this comment.
вот тут неэффективные вызовы на листе - parts.length + parts.apply(idx) ниже
мб через parts.iterator сделать?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#346