fix all blind texts being dark - #4
Open
nnmrts wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
loc_colouroverride only accepts a single parameter (key), but the vanilla function signature isloc_colour(_c, _default). When the override forwards to the original function vialoc_colour_ref(key), the_defaultparameter is silently dropped.The localization text parser calls
loc_colour(nil, args.default_col)for text segments without an explicit color code. Without the default being forwarded, the vanilla function falls through toG.C.UI.TEXT_DARK(#4F6367) instead of the caller's intended default color.This causes any localized text relying on the default color to render as dark gray instead of the expected color. Most visibly, blind description text, making it unreadable against the dark background.
Fix
Forward the
_defaultparameter through the override toloc_colour_ref.