Skip to content

feat: SW-2047 add background fill to checkbox and radio#158

Merged
54321jenn-ts merged 1 commit into
mainfrom
SW-2047-input-background-fill
Jul 2, 2026
Merged

feat: SW-2047 add background fill to checkbox and radio#158
54321jenn-ts merged 1 commit into
mainfrom
SW-2047-input-background-fill

Conversation

@boramyi-ts

@boramyi-ts boramyi-ts commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

SW-2047 — Add background colors on input components.

Checkbox and Radio render with a transparent (outline-only) fill in light mode, which makes them read as hollow next to the already-filled Input/Select/Textarea controls. This PR brings them in line with the established input pattern by adding the same bg-card surface fill.

  • Light mode: unchecked checkbox / radio now fill white (bg-card), matching text inputs and selects.
  • Dark mode: unchanged — keeps the existing dark:bg-input/30 subtle surface.
  • Checked / focus / invalid / disabled states are untouched.

Two-line change (checkbox.tsx, radio-group.tsx) — adds bg-card to the unchecked base; the existing dark:bg-input/30 already handled dark mode.

Type of Change

  • Bug fix / visual polish (non-breaking change)
  • New feature
  • Breaking change
  • Documentation

Checklist

  • yarn lint passes (zero warnings)
  • yarn typecheck passes
  • yarn build passes
  • yarn test:all passes (1203/1203)
  • New stories added (n/a — no API/behavior change)
  • Coverage updated (n/a)

Testing

No new Zephyr cases — this is a token-level visual change to existing components, no story or behavior changes. Existing checkbox and radio-group play tests pass unchanged.

Verification

Verified live in Storybook in both themes:

  • Light: unchecked checkbox/radio fill white, matching adjacent inputs.
  • Dark: appearance unchanged (input/30).
  • Checked / indeterminate / focus / invalid / disabled states verified unchanged in both themes.

Screenshots

Before

before

After

after

Give the unchecked checkbox and radio a background fill so they match the
filled affordance already used by Input and Select:

- Light: `bg-card` (white) — previously outline-only.
- Dark: keeps the existing `bg-input/30`.
- Checked state (`bg-primary`) and all other states unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@boramyi-ts boramyi-ts requested review from a team as code owners June 26, 2026 14:09
@boramyi-ts boramyi-ts temporarily deployed to artifactory-prod June 26, 2026 14:09 — with GitHub Actions Inactive
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ts-lib-ui-kit-storybook Ready Ready Preview, Comment Jul 2, 2026 2:27pm

Request Review

@github-actions

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 94.76% (🎯 83%)
🟰 ±0%
20699 / 21842
🟢 Statements 94.76% (🎯 83%)
🟰 ±0%
20699 / 21842
🟢 Functions 93.58% (🎯 74%)
🟰 ±0%
919 / 982
🟢 Branches 88.83% (🎯 81%)
🟰 ±0%
3804 / 4282
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/ui/checkbox.tsx 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
src/components/ui/radio-group.tsx 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
Generated in workflow #874 for commit e0d18cf by the Vitest Coverage Report Action

@54321jenn-ts 54321jenn-ts left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@54321jenn-ts 54321jenn-ts merged commit 4d5f703 into main Jul 2, 2026
15 checks passed
@54321jenn-ts 54321jenn-ts deleted the SW-2047-input-background-fill branch July 2, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants