feat: SW-2047 add background fill to checkbox and radio#158
Merged
Conversation
Give the unchecked checkbox and radio a background fill so they match the filled affordance already used by Input and Select: - Light: `bg-card` (white) — previously outline-only. - Dark: keeps the existing `bg-input/30`. - Checked state (`bg-primary`) and all other states unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
owilliams-tetrascience
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SW-2047 — Add background colors on input components.
Checkbox and Radio render with a transparent (outline-only) fill in light mode, which makes them read as hollow next to the already-filled
Input/Select/Textareacontrols. This PR brings them in line with the established input pattern by adding the samebg-cardsurface fill.bg-card), matching text inputs and selects.dark:bg-input/30subtle surface.Two-line change (
checkbox.tsx,radio-group.tsx) — addsbg-cardto the unchecked base; the existingdark:bg-input/30already handled dark mode.Type of Change
Checklist
yarn lintpasses (zero warnings)yarn typecheckpassesyarn buildpassesyarn test:allpasses (1203/1203)Testing
No new Zephyr cases — this is a token-level visual change to existing components, no story or behavior changes. Existing checkbox and radio-group play tests pass unchanged.
Verification
Verified live in Storybook in both themes:
input/30).Screenshots
Before
After