Skip to content

Align phone scanner with shared hints#23

Merged
alyldas merged 5 commits into
mainfrom
feat/shared-hints-phone-scanner
Jun 29, 2026
Merged

Align phone scanner with shared hints#23
alyldas merged 5 commits into
mainfrom
feat/shared-hints-phone-scanner

Conversation

@alyldas

@alyldas alyldas commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add boolean phone scanner checks and sink-based range streaming with early stop support.
  • Accept shared-style digit-count hints for low-digit rejection while preserving legacy scan(input) output.
  • Keep phone-specific parsing, validation, and false-positive guards inside the phone package.
  • Extend phone benchmarks with scanner setup, check(), low-digit, hinted clean, and late-match rows.

Validation

  • npm ci
  • npm run check
  • npm run benchmark:phone
  • npm pack --dry-run
  • Public runtime exports and package dry-run contents reviewed

Benchmarks

Latest phone benchmark highlights:

  • check hinted short clean: 0.0005 avg ms
  • check hinted low digit text: 0.0006 avg ms
  • check direct phone: 0.0087 avg ms
  • check late-match phone: 0.5673 avg ms
  • censor direct phone: 0.0104 avg ms
  • censor phone-like: 0.0081 avg ms
  • censor late-match phone: 0.6036 avg ms

Closes #22

No publish, no merge, no tag/release.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 422245c13c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/index.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 29f2ddfe10

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/index.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa7284f985

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/index.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 087e179c0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/index.ts Outdated
@alyldas alyldas merged commit 1873e7e into main Jun 29, 2026
4 checks passed
@alyldas alyldas deleted the feat/shared-hints-phone-scanner branch June 29, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Align phone scanner with shared hints and allocation-aware contract

1 participant