Conversation
`real_docker_satisfies_the_shared_suite` and
`kubernetes_satisfies_the_shared_suite` hit nextest's 60-second timeout on
Windows CI:
4642 tests run: 4640 passed, 2 timed out, 23 skipped
The same commit passed the push run and failed the pull-request run, which
is the shape of a result that depends on the machine rather than the code.
An earlier pass ignored three engine tests and stopped there, because those
were the three that had been seen to hang. These two were missed for a
reason worth recording: their own doc comments said the backend "answers"
`EngineMissing`/`NotConfigured` when the engine is absent. That is true only
where the CLI is absent too. Where the CLI is installed and the daemon is
not -- Windows CI -- the command waits, and the early return the comment
promised is never reached. Both comments now say so.
The remaining tests were audited rather than assumed: of the 18 that build a
real backend, 16 either only ask it for metadata or point it at a program
chosen to be absent (`zode-no-such-engine`, `false`), so they answer without
touching an engine. `acting_on_a_pod_refuses_and_explains` refuses from an
empty `supported_actions` before any spawn, and `kubernetes_offers_no_prune_
at_all` returns `None` outright. These two were the only ones left that
actually invoke one.
Verified both ways: `cargo nextest run -p container` is 56 passed / 8
skipped, and `--run-ignored all` runs them green on a machine with a live
daemon -- they are deferred, not broken.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Have feedback on this plugin? Let's hear it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
real_docker_satisfies_the_shared_suiteandkubernetes_satisfies_the_shared_suitehit nextest's 60-second timeout on Windows CI:The same commit passed the push run and failed the pull-request run, which is the shape of a result that depends on the machine rather than the code.
An earlier pass ignored three engine tests and stopped there, because those were the three that had been seen to hang. These two were missed for a reason worth recording: their own doc comments said the backend "answers"
EngineMissing/NotConfiguredwhen the engine is absent. That is true only where the CLI is absent too. Where the CLI is installed and the daemon is not -- Windows CI -- the command waits, and the early return the comment promised is never reached. Both comments now say so.The remaining tests were audited rather than assumed: of the 18 that build a real backend, 16 either only ask it for metadata or point it at a program chosen to be absent (
zode-no-such-engine,false), so they answer without touching an engine.acting_on_a_pod_refuses_and_explainsrefuses from an emptysupported_actionsbefore any spawn, andkubernetes_offers_no_prune_ at_allreturnsNoneoutright. These two were the only ones left that actually invoke one.Verified both ways:
cargo nextest run -p containeris 56 passed / 8 skipped, and--run-ignored allruns them green on a machine with a live daemon -- they are deferred, not broken.Self-Review Checklist:
Closes #ISSUE
Release Notes: