Skip to content

fix: remove contenthash from output filename to fix 404s in interactive mode #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xfsnowind merged 4 commits into from
Apr 9, 2026
Merged

fix: remove contenthash from output filename to fix 404s in interactive mode #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71517ff
fix: remove contenthash from output filename to fix 404 errors in int…
robcmills Apr 2, 2026
e8693f8
fix: replace contenthash with uniqueName to fix 404s in interactive mode
robcmills Apr 2, 2026
8b43efe
fix: use webpackChunkName magic comment instead of rspackChunkName
robcmills Apr 2, 2026
c0925dd
fix: revert unrelated snapshot change
robcmills Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dist/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const debug = (0, debug_1.default)('cypress-rspack-dev-server:rspack');
*/
const makeImport = (file, filename, chunkName) => {
// If we want to rename the chunks, we can use this
const magicComments = chunkName ? `/* rspackChunkName: "${chunkName}" */` : '';
const magicComments = chunkName ? `/* webpackChunkName: "${chunkName}" */` : '';
return `"${filename}": {
shouldLoad: () => {
const newLoad = new URLSearchParams(document.location.search).get("specPath") === "${file.absolute}";
Expand Down Expand Up @@ -42,7 +42,7 @@ const makeImport = (file, filename, chunkName) => {
return newLoad | oldLoad;
},
* load: () => {
* return import("/Users/projects/my-app/cypress/component/App.spec.js" \/* rspackChunkName: "spec-0" *\/)
* return import("/Users/projects/my-app/cypress/component/App.spec.js" \/* webpackChunkName: "spec-0" *\/)
* },
* chunkName: "spec-0"
* }
Expand Down Expand Up @@ -89,7 +89,7 @@ function loader() {
var supportFile = {
absolute: ${supportFileAbsolutePath},
relative: ${supportFileRelativePath},
load: () => import(/* rspackChunkName: "cypress-support-file" */ ${supportFileAbsolutePath}),
load: () => import(/* webpackChunkName: "cypress-support-file" */ ${supportFileAbsolutePath}),
}
scriptLoaders.unshift(supportFile)
}
Expand Down
3 changes: 2 additions & 1 deletion dist/makeDefaultRspackConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,10 @@ function makeCypressRspackConfig(config) {
mode: 'development',
optimization,
output: {
filename: '[name].[contenthash].js',
filename: '[name].js',
path: OUTPUT_PATH,
publicPath,
uniqueName: 'cypress-rspack-dev-server',
},
plugins: [
new core_1.HtmlRspackPlugin({
Expand Down
6 changes: 3 additions & 3 deletions src/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const debug = debugFn('cypress-rspack-dev-server:rspack')
*/
const makeImport = (file: Cypress.Cypress['spec'], filename: string, chunkName: string) => {
// If we want to rename the chunks, we can use this
const magicComments = chunkName ? `/* rspackChunkName: "${chunkName}" */` : ''
const magicComments = chunkName ? `/* webpackChunkName: "${chunkName}" */` : ''

return `"${filename}": {
shouldLoad: () => {
Expand Down Expand Up @@ -47,7 +47,7 @@ const makeImport = (file: Cypress.Cypress['spec'], filename: string, chunkName:
return newLoad | oldLoad;
},
* load: () => {
* return import("/Users/projects/my-app/cypress/component/App.spec.js" \/* rspackChunkName: "spec-0" *\/)
* return import("/Users/projects/my-app/cypress/component/App.spec.js" \/* webpackChunkName: "spec-0" *\/)
* },
* chunkName: "spec-0"
* }
Expand Down Expand Up @@ -99,7 +99,7 @@ export default function loader(this: unknown) {
var supportFile = {
absolute: ${supportFileAbsolutePath},
relative: ${supportFileRelativePath},
load: () => import(/* rspackChunkName: "cypress-support-file" */ ${supportFileAbsolutePath}),
load: () => import(/* webpackChunkName: "cypress-support-file" */ ${supportFileAbsolutePath}),
}
scriptLoaders.unshift(supportFile)
}
Expand Down
3 changes: 2 additions & 1 deletion src/makeDefaultRspackConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@ export function makeCypressRspackConfig(config: CreateFinalRspackConfig): Config
mode: 'development',
optimization,
output: {
filename: '[name].[contenthash].js',
filename: '[name].js',
path: OUTPUT_PATH,
publicPath,
uniqueName: 'cypress-rspack-dev-server',
},
plugins: [
new HtmlRspackPlugin({
Expand Down
Loading