fix: #49 fix the bug of split chunks algorithm with rspack 2#50
Merged
Conversation
aec8978 to
199a76d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #49 — Disables
splitChunksin the default Cypress rspack config to prevent module loading failures with Rspack v2 on Linux.Problem
The
splitChunks: { chunks: 'all' }setting (inherited from Cypress's official@cypress/webpack-dev-server) causes Rspack v2's chunk splitting algorithm to produce broken chunk boundaries on Linux. A transitive dependency gets placed in a separate chunk that hasn't loaded when the spec module evaluates, resulting in:The issue is platform-specific — it reproduces on Linux (
@rspack/binding-linux-x64-gnu) but not on macOS (@rspack/binding-darwin-arm64) with identicalnode_modules.Why this fix is safe
Chunk splitting is not beneficial for Cypress component testing — all code runs in a single test iframe. There's no performance gain from shared vendor chunks in this context. The
splitChunksconfig was inherited from Cypress's webpack-dev-server where it works correctly with webpack's chunk loading runtime, but Rspack v2's rewritten@rspack/dev-server(no longer based onwebpack-dev-server) handles chunk loading differently.Changes
src/makeDefaultRspackConfig.ts:splitChunks: { chunks: 'all' }→splitChunks: falsedist/makeDefaultRspackConfig.js: same change in compiled output