V0.6.3/livebook fixes#223
Merged
Merged
Conversation
Before: The coverage matrix cell ran mix coveralls.html, parsed [TOTAL] from stdout, enforced a 70% floor, and uploaded cover/ as an artifact.
After: On the coverage matrix cell (1.20 / OTP 29):
- name: Run coverage
if: ${{ matrix.coverage }}
run: mix coveralls.github --include adbc_package:true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Non-coverage matrix cells still run mix test only.
Notes:
Kept --include adbc_package:true from the previous step.
Removed the artifact upload; Coveralls gets the report via the GitHub API.
The inline 70% gate is gone — set a threshold in Coveralls if you still want CI to fail on low coverage.
merging back the coverage badge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.