Fix analyzer button in FF window - #3
Open
HansDeutscher wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there!
The game recently made some minor changes to the FF window layout. This messed up the position of the analyzer button which will now hover over the number of defenders currently alive. This is slightly annoying so decided to reposition the button.
Instead of using the absolute position within the pane (tw2gui_window_content_pane), I believe it would be better to just insert the button into the grid of buttons (fort_battle_buttons) and align the CSS styles with the rest of other buttons.
While this works for most situations, in case you are also a general rank, you will see more buttons in the grid and the grid would overflow on the left side outside the background box which is visually unpleasant. Attempted to fix that too by shifting the entire grid slightly more to the right. I am not experienced with overriding CSS styles via Tampermonkey - what I found works is the old ugly !important way. If there's a better way to do this, let me know.
This is what the buttons look like now for captain ranks and below with my changes:
And this is what the buttons look like now with all possible buttons available at the same time:
Cheers!