ci(release): consume thaw-app/org-ci macOS actions - #824
Merged
Conversation
Point release/DMG workflows at org-qualified composite actions so Thaw can use shared packaging CI before it joins the org.
Contributor
📝 WalkthroughWalkthroughThe repository-local macOS composite actions were removed. The DMG and release workflows now invoke pinned shared actions for signing, building, packaging, notarization, and Sparkle release generation. ChangesmacOS CI action centralization
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ReleaseWorkflow
participant SharedCI
participant Xcode
participant AppleNotary
ReleaseWorkflow->>SharedCI: Configure signing
SharedCI->>Xcode: Build and export archive
Xcode->>SharedCI: Return packaged DMG
SharedCI->>AppleNotary: Notarize and validate DMG
AppleNotary->>SharedCI: Return accepted status
SharedCI->>ReleaseWorkflow: Publish Sparkle ZIP and appcast outputs
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bump thaw-app/org-ci pins to the commit that addresses keychain, Sparkle key cleanup, and build/notarize contract fixes.
Bump thaw-app/org-ci pins to include ExportOptions.plist creation before PlistBuddy Add.
Bump thaw-app/org-ci pins to the commit that hardens keychain/cert cleanup, notarize status ordering, and create-dmg retries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move macOS release composite actions out of Thaw and call the public org copies via org-qualified
uses:pins (Thaw is not underthaw-appyet).Scope: replace local
.github/actions/*withthaw-app/org-ci/actions/…@d8439b09dfc7dda7323906cd0daeef1752c4bb2ain release/DMG workflows; delete the in-repo action copies.Closes: N/A
PR Type
Describe what this change does (not the linked issue’s request kind). Bug reports use
bugon issues; bug fixes usefixon PRs.If you tick Feature or Refactor and touch more than ~20 files, please mention why this can’t be split.
Area
Product surfaces (optional when the change is not about the app UI). Path-based labeling also applies.
Use PR Type for what changed (
CI/CD,Documentation,Other/ chore, etc.).Use
opsfor where when it is repo operations: CI, release, GitHub hygiene, scripts, lint/sonar config — not a product surface.menubar
icebar
layout
appearance
settings
onboarding
permissions
profiles
hotkeys
updates
ops
Does this PR introduce a breaking change?
What is the new behavior?
release.yml/build-dmg.ymlcall:thaw-app/org-ci/actions/configure-signing@d8439b09dfc7dda7323906cd0daeef1752c4bb2athaw-app/org-ci/actions/build@d8439b09dfc7dda7323906cd0daeef1752c4bb2athaw-app/org-ci/actions/export-and-package@d8439b09dfc7dda7323906cd0daeef1752c4bb2athaw-app/org-ci/actions/notarize-and-validate@d8439b09dfc7dda7323906cd0daeef1752c4bb2athaw-app/org-ci/actions/sparkle-release@d8439b09dfc7dda7323906cd0daeef1752c4bb2a(release only).github/actions/composites are removedThaw.xcodeproj, scheme, deployment target,asset-prefix: Thaw) stay in Thaw workflowsthaw-app/brand-assets(via the org action)Merge after thaw-app/org-ci#1 (pin points at the latest fix commit on that PR).
PR Checklist
swiftformat .to keep the code style consistent.xcodebuild test …orswift test --package-path MenuBarModel.developmentbranch.Test commands run:
build-dmg/ release workflow run)Known limitations / follow-ups
mainif desiredOther information
Companion: thaw-app/org-ci#1
Summary by CodeRabbit