Skip to content

fix(s3): use AWS SDK default credential chain when explicit keys are absent #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ct3685 merged 1 commit into from
May 20, 2026
Merged

fix(s3): use AWS SDK default credential chain when explicit keys are absent #1079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions packages/server/src/services/csv-parser/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,23 @@ const createCsvParseRun = async (user: IUser, body: any) => {
const fileBuffer = Buffer.from(base64Data, 'base64')

// Upload file to S3
const s3 = new S3Client({
region: process.env.S3_STORAGE_REGION ?? 'us-east-1',
credentials: {
accessKeyId: process.env.S3_STORAGE_ACCESS_KEY_ID ?? '',
secretAccessKey: process.env.S3_STORAGE_SECRET_ACCESS_KEY ?? ''
const s3Config: any = {
region: process.env.S3_STORAGE_REGION ?? 'us-east-1'
}
// Only set explicit credentials when present — otherwise the AWS SDK
// falls through to the default credential chain (IAM roles, ECS task
// roles, Copilot-injected env, etc.)
if (process.env.S3_STORAGE_ACCESS_KEY_ID && process.env.S3_STORAGE_SECRET_ACCESS_KEY) {
s3Config.credentials = {
accessKeyId: process.env.S3_STORAGE_ACCESS_KEY_ID,
secretAccessKey: process.env.S3_STORAGE_SECRET_ACCESS_KEY
}
})
}
if (process.env.S3_ENDPOINT_URL) {
s3Config.endpoint = process.env.S3_ENDPOINT_URL
s3Config.forcePathStyle = true
}
const s3 = new S3Client(s3Config)
await s3.send(
new PutObjectCommand({
Bucket: process.env.S3_STORAGE_BUCKET_NAME ?? '',
Expand Down
Loading