fix(AGENT-679): enable TypeScript type-checking in CI and next build#958
fix(AGENT-679): enable TypeScript type-checking in CI and next build#958maxtechera wants to merge 1 commit into
Conversation
Fix all 162 TS errors, set ignoreBuildErrors to false, add tsc --noEmit to CI workflow.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review: fix(AGENT-679): enable TypeScript type-checking in CI and next buildSummaryThis PR addresses a critical production issue where TypeScript errors weren't caught during build time, leading to a ReferenceError in production (AGENT-678). The changes fix 162 TypeScript errors across 59 files, enable type-checking in both Next.js builds and CI, and add proper tooling to prevent future type-related issues. Positive Aspects ✅Critical Infrastructure Improvements
Critical Issues 🚨1. Overuse of Type Assertions (
|
Summary
apps/web/,packages-answers/ui/, andpackages-answers/utils/ignoreBuildErrors: falseinapps/web/next.config.jstsc --noEmitstep to.github/workflows/main.yml(NodeCI)typecheckscript toapps/web/package.jsonContext
Discovered after AGENT-678 shipped a
ReferenceError: isFilterExpanded is not definedto production — an error thattscwould have caught at build time. Root cause: no TypeScript type-checking was running anywhere in the pipeline.Test plan
pnpm --filter web tsc --noEmitpasses with 0 errorspnpm --filter web buildpasses (next build now checks types)Linear: https://linear.app/answeragent/issue/AGENT-679