fix(AGENT-675): update embed submodule with multi-tab localStorage fix#973
fix(AGENT-675): update embed submodule with multi-tab localStorage fix#973diecoscai wants to merge 4 commits into
Conversation
Point embed submodule to feature branch with sessionStorage isolation. Add testing guide for manual QA of multi-tab chat behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previous commits pointed to AGENT-661 branch by mistake. Now points to commit 171510c which has the sessionStorage isolation for multi-tab chat. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Revert AGENT-654 marketplace fix, remove plan docs, and restore test/settings files to keep PR focused on embed submodule fix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review: fix(AGENT-675): update embed submodule with multi-tab localStorage fixReviewer: Claude Code Review Summary of ChangesThis PR updates the The diff is a single-line change in the submodule reference: -Subproject commit be0c9d34bae9c773a3becf60635c4b5d72b5b4bf
+Subproject commit 171510c322eb582b019d5e94fe328ec035c9d242This is a submodule-only PR with no changes to application source code, routes, controllers, services, or database logic. SecurityNo security concerns apply to this change. This is a submodule pointer update with no:
Multi-Tenancy and AuthenticationNot applicable. No server-side code was modified. Critical IssuesNone identified. The change is scoped entirely to the submodule commit reference. Suggestions1. Verify the submodule points to a merged or stable commit on the correct branch The
The commit history for this PR shows some iteration ("pointed to AGENT-661 branch by mistake"), which suggests the submodule target has been corrected — good. Just ensure the final pointer is to a stable, mergeable-branch commit. 2. Manual QA steps in the test plan are clear and appropriate The test plan lists meaningful steps for verifying the fix:
Consider adding one more scenario: verifying that the feedback attribution (the specific bug mentioned in the Linear ticket AGENT-675) works correctly across tabs after the fix. This would provide direct regression coverage for the reported issue. 3. No automated tests cover the embed widget This is expected for a submodule update, but it is worth noting for future work. The embed widget behavior (sessionStorage isolation, multi-tab correctness) is only verifiable via manual QA since it lives in a separate repository. If the Positive Observations
Overall RecommendationApprove (with minor suggestion) This is a low-risk, well-scoped submodule pointer update. The only action item before merging is to confirm that commit Review conducted by Claude Code Review Agent |
|
Clarification for AGENT-675 rollout: This PR is correct in scope (submodule bump), but merge readiness depends on the other PR: Reason:
Required sequence:
So this is a dependency/ordering blocker, not an implementation-quality issue in this PR. |
Summary
Updates
packages/embedsubmodule to ship AGENT-675 (multi-tab chat isolation) intotheanswer.Why this PR exists
theanswerconsumesaai-embedvia git submodule. To deliver AGENT-675 in product, we need this repo to pointpackages/embedat the correctaai-embedcommit.Important dependency
the-answerai/aai-embed#26a-maincommit produced by Feature/beta v1 updated #26 (and post-merge automation, if any), not to a detached feature-only SHA.What AGENT-675 includes (in aai-embed)
Current status / follow-up
This PR currently contains only the submodule pointer update. Before merge, it should be refreshed so
packages/embedpoints to the finala-maincommit that contains AGENT-675 fromaai-embed#26.Validation checklist
aai-embed#26merged toa-mainpackages/embedpointer in this PR is reachable fromorigin/a-mainImpact
theanswer; submodule version update only.Linear
AGENT-675