Skip to content

fix(AGENT-675): update embed submodule with multi-tab localStorage fix#973

Open
diecoscai wants to merge 4 commits into
stagingfrom
feature/AGENT-675-fix-embed-multi-tab-localstorage
Open

fix(AGENT-675): update embed submodule with multi-tab localStorage fix#973
diecoscai wants to merge 4 commits into
stagingfrom
feature/AGENT-675-fix-embed-multi-tab-localstorage

Conversation

@diecoscai
Copy link
Copy Markdown

@diecoscai diecoscai commented Feb 19, 2026

Summary

Updates packages/embed submodule to ship AGENT-675 (multi-tab chat isolation) into theanswer.

Why this PR exists

theanswer consumes aai-embed via git submodule. To deliver AGENT-675 in product, we need this repo to point packages/embed at the correct aai-embed commit.

Important dependency

  • Source implementation PR: the-answerai/aai-embed#26
  • This PR must point to the final a-main commit produced by Feature/beta v1 updated #26 (and post-merge automation, if any), not to a detached feature-only SHA.

What AGENT-675 includes (in aai-embed)

  • Session-storage-first tab isolation in chatbot state.
  • Local-storage fallback for compatibility and returning users.
  • Dual-write for feedback/lead consistency.
  • Safety fixes in storage helpers (fallback handling + lead preservation on clear).

Current status / follow-up

This PR currently contains only the submodule pointer update. Before merge, it should be refreshed so packages/embed points to the final a-main commit that contains AGENT-675 from aai-embed#26.

Validation checklist

  • aai-embed#26 merged to a-main
  • packages/embed pointer in this PR is reachable from origin/a-main
  • CI checks pass on this PR after pointer refresh

Impact

  • Fixes multi-tab state collision behavior in embedded chat.
  • No API contract changes in theanswer; submodule version update only.

Linear

AGENT-675

diecoscai and others added 4 commits February 19, 2026 20:30
Point embed submodule to feature branch with sessionStorage isolation.
Add testing guide for manual QA of multi-tab chat behavior.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previous commits pointed to AGENT-661 branch by mistake. Now points to
commit 171510c which has the sessionStorage isolation for multi-tab chat.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Revert AGENT-654 marketplace fix, remove plan docs, and restore
test/settings files to keep PR focused on embed submodule fix.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@diecoscai diecoscai self-assigned this Feb 19, 2026
@linear
Copy link
Copy Markdown

linear Bot commented Feb 19, 2026

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
answerai-docs Building Building Preview Feb 19, 2026 11:36pm
the-answerai Building Building Preview Feb 19, 2026 11:36pm

Request Review

@claude
Copy link
Copy Markdown

claude Bot commented Feb 19, 2026

PR Review: fix(AGENT-675): update embed submodule with multi-tab localStorage fix

Reviewer: Claude Code Review
Date: 2026-02-19
PR Size: Minimal (1 addition, 1 deletion — submodule pointer update only)


Summary of Changes

This PR updates the packages/embed git submodule pointer from commit be0c9d34bae to commit 171510c322e. According to the PR description, the target commit contains a fix for multi-tab localStorage conflicts in the embed widget — where state (such as feedback attribution) was leaking between browser tabs sharing the same localStorage keys.

The diff is a single-line change in the submodule reference:

-Subproject commit be0c9d34bae9c773a3becf60635c4b5d72b5b4bf
+Subproject commit 171510c322eb582b019d5e94fe328ec035c9d242

This is a submodule-only PR with no changes to application source code, routes, controllers, services, or database logic.


Security

No security concerns apply to this change. This is a submodule pointer update with no:

  • Route definitions (no authentication middleware review needed)
  • Database queries (no multi-tenancy / organizationId filter review needed)
  • Controller logic (no checkOwnership() review needed)
  • Hardcoded secrets, SQL interpolation, or XSS vectors

Multi-Tenancy and Authentication

Not applicable. No server-side code was modified.


Critical Issues

None identified. The change is scoped entirely to the submodule commit reference.


Suggestions

1. Verify the submodule points to a merged or stable commit on the correct branch

The .gitmodules file specifies branch = a-main as the tracked branch for packages/embed. The PR description states the fix lives at commit 171510c. It would be worth confirming:

  • That 171510c exists on the a-main branch (or the intended release branch) of aai-embed, rather than on a feature branch that could be rebased or force-pushed in the future.
  • If 171510c is on a feature branch, consider waiting for it to be merged to a-main before updating the pointer here, or document explicitly that this is intentional.

The commit history for this PR shows some iteration ("pointed to AGENT-661 branch by mistake"), which suggests the submodule target has been corrected — good. Just ensure the final pointer is to a stable, mergeable-branch commit.

2. Manual QA steps in the test plan are clear and appropriate

The test plan lists meaningful steps for verifying the fix:

  • Open embed widget in two tabs
  • Interact with chat in both tabs simultaneously
  • Verify localStorage state does not leak between tabs
  • Verify single-tab usage still works

Consider adding one more scenario: verifying that the feedback attribution (the specific bug mentioned in the Linear ticket AGENT-675) works correctly across tabs after the fix. This would provide direct regression coverage for the reported issue.

3. No automated tests cover the embed widget

This is expected for a submodule update, but it is worth noting for future work. The embed widget behavior (sessionStorage isolation, multi-tab correctness) is only verifiable via manual QA since it lives in a separate repository. If the aai-embed repo has its own test suite, confirming that tests pass there would strengthen confidence in this update.


Positive Observations

  • The PR is tightly scoped. The final cleanup commit (chore(AGENT-675): remove unrelated changes from PR) shows good discipline in keeping the PR focused on a single concern.
  • The PR description is clear, explains the problem, the fix, and the impact accurately.
  • PR targets staging, not main — correct per project conventions.
  • Commit messages follow the conventional commit format (fix(AGENT-675): ...) consistently across all commits.
  • The Linear ticket is linked and the branch name matches the ticket ID (feature/AGENT-675-...).
  • The backwards-compatibility claim ("no breaking changes") is credible for a submodule pointer update of this nature.
  • CI checks (CodeQL, Vercel preview deployments) are running as expected.

Overall Recommendation

Approve (with minor suggestion)

This is a low-risk, well-scoped submodule pointer update. The only action item before merging is to confirm that commit 171510c322e in aai-embed is on a stable branch (preferably a-main) and will not be subject to rebase or force-push. If that is confirmed, this PR is ready to merge.


Review conducted by Claude Code Review Agent

@diecoscai
Copy link
Copy Markdown
Author

Clarification for AGENT-675 rollout:

This PR is correct in scope (submodule bump), but merge readiness depends on the other PR:

Reason:

  • theanswer consumes aai-embed via packages/embed submodule.
  • This PR should point to the final a-main SHA produced by Feature/beta v1 updated #26 after that PR is merged.

Required sequence:

  1. Merge aai-embed#26 into a-main
  2. Update packages/embed in this PR to that resulting SHA
  3. Re-run CI
  4. Merge this PR

So this is a dependency/ordering blocker, not an implementation-quality issue in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant