refactor(config): split config.go and rename fields to camelCase #157
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| package config | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "log" | ||
| "os" | ||
| "path/filepath" | ||
| "strconv" | ||
|
|
||
| "github.com/joho/godotenv" | ||
| ) | ||
|
|
||
| func loadEnvFile() { | ||
|
Contributor
There was a problem hiding this comment. We should not be using files for environment variable? Why is this function present? |
||
| if os.Getenv("APP_ENV") == "production" { | ||
| return | ||
| } | ||
|
|
||
| cwd, err := os.Getwd() | ||
| if err != nil { | ||
| log.Fatalf("failed to determine current working directory: %v", err) | ||
| } | ||
|
|
||
| envPath, err := findEnvFile(cwd) | ||
| if err != nil { | ||
| if errors.Is(err, os.ErrNotExist) { | ||
| log.Println("config: no .env file found - environment variables used as-is") | ||
| return | ||
| } | ||
| log.Fatalf("failed to locate .env file: %v", err) | ||
| } | ||
|
|
||
| if err := godotenv.Load(envPath); err != nil { | ||
| log.Fatalf("failed to load .env file %q: %v", envPath, err) | ||
| } | ||
|
|
||
| log.Printf("config: env loaded from %s", envPath) | ||
| } | ||
|
|
||
| func findEnvFile(startDir string) (string, error) { | ||
| dir := startDir | ||
| for { | ||
| candidate := filepath.Join(dir, ".env") | ||
| info, err := os.Stat(candidate) | ||
| if err == nil && !info.IsDir() { | ||
| return candidate, nil | ||
| } | ||
| if err != nil && !errors.Is(err, os.ErrNotExist) { | ||
| return "", err | ||
| } | ||
|
|
||
| parent := filepath.Dir(dir) | ||
| if parent == dir { | ||
| break | ||
| } | ||
| dir = parent | ||
| } | ||
|
|
||
| return "", os.ErrNotExist | ||
| } | ||
|
|
||
| func postgresPortFromEnv() (int, error) { | ||
|
Contributor
There was a problem hiding this comment. Did not get the point of this function. Why do we need a function to get port of postgres? |
||
| rawPort := os.Getenv("POSTGRES_PORT") | ||
| if rawPort == "" { | ||
| return 5432, nil | ||
| } | ||
|
|
||
| port, err := strconv.Atoi(rawPort) | ||
| if err != nil { | ||
| return 0, fmt.Errorf("invalid POSTGRES_PORT %q: must be numeric", rawPort) | ||
| } | ||
| if port <= 0 { | ||
| return 0, fmt.Errorf("invalid POSTGRES_PORT %q: must be greater than 0", rawPort) | ||
| } | ||
|
|
||
| return port, nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package config | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strings" | ||
| ) | ||
|
|
||
| func validateDatabaseConfig(cfg AppConfig) error { | ||
| missing := make([]string, 0, 4) | ||
|
|
||
| if cfg.PostgresUser == "" { | ||
|
Contributor
There was a problem hiding this comment. Are if statements the only thing we can do? |
||
| missing = append(missing, "POSTGRES_USER") | ||
| } | ||
| if cfg.PostgresPassword == "" { | ||
| missing = append(missing, "POSTGRES_PASSWORD") | ||
| } | ||
| if cfg.PostgresDB == "" { | ||
| missing = append(missing, "POSTGRES_DB") | ||
| } | ||
| if cfg.PostgresHost == "" { | ||
| missing = append(missing, "POSTGRES_HOST") | ||
| } | ||
| if len(missing) > 0 { | ||
| return fmt.Errorf("missing required database config: %s", strings.Join(missing, ", ")) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is camel case related to some go conventions? Usually constants are defined as snake case capital letters