Chore/650 upgrade zod v4 - #680
Open
shivamvishwakarm wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for incredible-eclair-ada155 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
🏷️ [bumpr] |
atul030702
approved these changes
Aug 12, 2026
Collaborator
|
Link this PR properly, also this PR only upgrades the repo and changes the existing code. When will we incorporate the features provided by the v4 in this? |
TanishqSingla
requested changes
Aug 12, 2026
Comment on lines
+5
to
+8
| .string({ | ||
| error: (issue) => | ||
| issue.input === undefined ? 'Preview title is required' : undefined, | ||
| }) |
Collaborator
There was a problem hiding this comment.
A custom error message is already there on the .min function. You should have fixed this if you're changing this code
Comment on lines
+11
to
+16
| .string({ | ||
| error: (issue) => | ||
| issue.input === undefined | ||
| ? 'Preview subheading is required' | ||
| : undefined, | ||
| }) |
Comment on lines
+6
to
+8
| error: (issue) => | ||
| issue.input === undefined ? 'Password is required' : undefined, | ||
| }) |
Collaborator
There was a problem hiding this comment.
for most of the validation error message you don't need to define a callback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Why Merge This PR?
This PR update :
Zod v4:
Zod v3:
Reference: https://zod.dev/v4/changelog
🛠️ Issue Fixed
fixes #650
🔍 PR Type