Skip to content

snapshot-editor-ux-improvements #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harimouli wants to merge 1 commit into
base: main
Choose a base branch
from
+137 −121
Open

snapshot-editor-ux-improvements #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions apps/the_monkeys/src/features/snapshot/components/SnapshotPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,9 @@ export interface SnapshotPreviewProps {
/** Background "stage" colour around the canvas. */
stageBackground?: string;
className?: string;
previewHeight?: number;
}

/**
* Renders the selected template at its native px size inside a fixed-size
* wrapper, then scales the wrapper with CSS `transform` so the visible preview
* fits the available area without affecting the export pipeline (which still
* reads the native dimensions via a ref).
*/
export const SnapshotPreview = forwardRef<HTMLDivElement, SnapshotPreviewProps>(
function SnapshotPreview(
{
Expand All @@ -34,6 +29,7 @@ export const SnapshotPreview = forwardRef<HTMLDivElement, SnapshotPreviewProps>(
maxPreviewWidth,
stageBackground = 'transparent',
className,
previewHeight,
},
ref
) {
Expand All @@ -44,20 +40,33 @@ export const SnapshotPreview = forwardRef<HTMLDivElement, SnapshotPreviewProps>(

useEffect(() => {
if (!stageRef.current) return;

const el = stageRef.current;

const update = () => {
const available = maxPreviewWidth ?? el.clientWidth;
if (!available) return;
const next = Math.min(1, available / template.width);
const availableWidth = maxPreviewWidth ?? el.clientWidth;

if (!availableWidth) return;

let next = Math.min(1, availableWidth / template.width);

if (previewHeight) {
next = Math.min(next, previewHeight / template.height);
}

setScale(next);
};

update();

const ro = new ResizeObserver(update);
ro.observe(el);

return () => ro.disconnect();
}, [template.width, maxPreviewWidth]);
}, [template.width, maxPreviewWidth, previewHeight]);

const Render = template.Render;

const scaledWidth = template.width * scale;
const scaledHeight = template.height * scale;

Expand All @@ -76,15 +85,9 @@ export const SnapshotPreview = forwardRef<HTMLDivElement, SnapshotPreviewProps>(
overflow: 'hidden',
marginLeft: 'auto',
marginRight: 'auto',
backgroundColor: stageBackground,
}}
>
{/*
* The CSS scale lives on this wrapper, NOT on the ref'd
* element below. If we put `transform` on the export root,
* html-to-image would serialize the transform into its
* SVG output and produce a tiny image in the top-left of
* a native-sized canvas.
*/}
<div
style={{
width: template.width,
Expand Down
221 changes: 117 additions & 104 deletions apps/the_monkeys/src/features/snapshot/components/SnapshotStudio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ export const SnapshotStudio = ({
const [exportMode, setExportMode] = useState<'image' | 'video-overlay'>(
'image'
);

const tweetCanvasSize = TWEET_ASPECT_DIMENSIONS[tweetOptions.aspect];

const tweetId = useMemo(() => parseTweetId(tweetUrl), [tweetUrl]);
Expand Down Expand Up @@ -139,6 +138,24 @@ export const SnapshotStudio = ({
return () => ro.disconnect();
}, [previewMode, tweetCanvasSize.width]);

const [previewHeight, setPreviewHeight] = useState<number | undefined>(
undefined
);

useEffect(() => {
const updatePreviewHeight = () => {
setPreviewHeight(Math.max(400, window.innerHeight - 180));
};

updatePreviewHeight();

window.addEventListener('resize', updatePreviewHeight);

return () => {
window.removeEventListener('resize', updatePreviewHeight);
};
}, []);

const { exportImage, isExporting, error } = useExport(snapshotRef, {
width: template.width,
height: template.height,
Expand Down Expand Up @@ -325,116 +342,117 @@ export const SnapshotStudio = ({
<div
className={cn(
'grid w-full grid-cols-1 gap-6',
previewMode === 'x'
? 'lg:grid-cols-[minmax(320px,400px)_1fr]'
: 'lg:grid-cols-[1fr_minmax(320px,420px)]'
'lg:grid-cols-[minmax(0,1fr)_minmax(320px,420px)]'
)}
>
<section
className={cn(
'flex min-w-0 flex-col gap-3',
previewMode === 'x' ? 'lg:order-2' : ''
)}
>
<div>
<h2 className='font-newsreader text-2xl'>
{previewMode === 'x' ? 'X post screenshot' : template.label}
</h2>
<p className='text-xs text-foreground/60'>
{previewMode === 'x'
? tweetId
? `${tweetCanvasSize.width}×${tweetCanvasSize.height} · Clean screenshot card`
: 'Paste a public X post URL'
: `${template.width}×${template.height} · ${template.aspect}`}
</p>
</div>

<div className='rounded-2xl border bg-foreground-light/30 p-2 dark:bg-foreground-dark/20 sm:p-4'>
{previewMode === 'template' ? (
<SnapshotPreview
ref={snapshotRef}
input={renderedInput}
templateId={state.templateId}
themeId={state.themeId}
accent={state.accent}
/>
) : (
<div className='flex flex-col items-center w-full'>
<div
ref={xStageRef}
className='flex justify-center p-2 w-full overflow-hidden'
>
<section className='flex min-w-0 flex-col gap-3'>
<div className='min-w-0 lg:sticky lg:top-24'>
<div>
<h2 className='font-newsreader text-2xl'>
{previewMode === 'x' ? 'X post screenshot' : template.label}
</h2>

<p className='text-xs text-foreground/60'>
{previewMode === 'x'
? tweetId
? `${tweetCanvasSize.width}×${tweetCanvasSize.height} · Clean screenshot card`
: 'Paste a public X post URL'
: `${template.width}×${template.height} · ${template.aspect}`}
</p>
</div>

<div className='mt-3 min-w-0 max-w-full overflow-hidden'>
{previewMode === 'template' ? (
<SnapshotPreview
ref={snapshotRef}
input={renderedInput}
templateId={state.templateId}
themeId={state.themeId}
accent={state.accent}
previewHeight={previewHeight}
/>
) : (
<div className='flex flex-col items-center w-full'>
<div
style={{
width: tweetCanvasSize.width * xScale,
height: tweetCanvasSize.height * xScale,
overflow: 'hidden',
position: 'relative',
}}
ref={xStageRef}
className='flex justify-center p-2 w-full overflow-hidden'
>
<div
className='relative'
style={{
width: tweetCanvasSize.width,
height: tweetCanvasSize.height,
transform: `scale(${xScale})`,
transformOrigin: 'top left',
width: tweetCanvasSize.width * xScale,
height: tweetCanvasSize.height * xScale,
overflow: 'hidden',
position: 'relative',
}}
>
<TweetScreenshotPreview
ref={tweetPreviewRef}
tweetUrl={tweetUrl}
options={tweetOptions}
onError={setTweetLoadError}
onTweetReady={setTweetForDownload}
exportMode={exportMode}
/>

{/* Decorative drag handles to replicate layout design */}
<div
className='absolute left-0 top-1/2 -translate-x-1/2 -translate-y-1/2 w-2.5 h-7 bg-white rounded-full border border-black/10 shadow-lg z-10'
style={{ pointerEvents: 'none' }}
/>
<div
className='absolute right-0 top-1/2 translate-x-1/2 -translate-y-1/2 w-2.5 h-7 bg-white rounded-full border border-black/10 shadow-lg z-10'
style={{ pointerEvents: 'none' }}
/>
<div
className='absolute bottom-0 left-1/2 -translate-x-1/2 translate-y-1/2 w-7 h-2.5 bg-white rounded-full border border-black/10 shadow-lg z-10'
style={{ pointerEvents: 'none' }}
/>
className='relative'
style={{
width: tweetCanvasSize.width,
height: tweetCanvasSize.height,
transform: `scale(${xScale})`,
transformOrigin: 'top left',
}}
>
<TweetScreenshotPreview
ref={tweetPreviewRef}
tweetUrl={tweetUrl}
options={tweetOptions}
onError={setTweetLoadError}
onTweetReady={setTweetForDownload}
exportMode={exportMode}
/>

{/* Decorative drag handles to replicate layout design */}
<div
className='absolute left-0 top-1/2 -translate-x-1/2 -translate-y-1/2 w-2.5 h-7 bg-white rounded-full border border-black/10 shadow-lg z-10'
style={{ pointerEvents: 'none' }}
/>

<div
className='absolute right-0 top-1/2 translate-x-1/2 -translate-y-1/2 w-2.5 h-7 bg-white rounded-full border border-black/10 shadow-lg z-10'
style={{ pointerEvents: 'none' }}
/>

<div
className='absolute bottom-0 left-1/2 -translate-x-1/2 translate-y-1/2 w-7 h-2.5 bg-white rounded-full border border-black/10 shadow-lg z-10'
style={{ pointerEvents: 'none' }}
/>
</div>
</div>
</div>
</div>

{/* Stage description footer */}
<div className='mt-6 text-center text-xs text-foreground/50 flex flex-col gap-1.5'>
<p>
But if you like this tool, you can always{' '}
<a
href='https://github.com/sponsors/the-monkeys'
target='_blank'
rel='noopener noreferrer'
className='text-brand-orange hover:underline font-medium'
>
fund us on github.com.co
</a>
</p>
<p>
Issues?{' '}
<a
href='mailto:support@monkeys.com.co'
className='text-brand-orange hover:underline font-medium'
>
Contact us
</a>
</p>
<p className='text-[10px] text-foreground/40 mt-1'>
Works instantly on mobile or desktop and every browser
</p>
{/* Stage description footer */}
<div className='mt-6 text-center text-xs text-foreground/50 flex flex-col gap-1.5'>
<p>
But if you like this tool, you can always{' '}
<a
href='https://github.com/sponsors/the-monkeys'
target='_blank'
rel='noopener noreferrer'
className='text-brand-orange hover:underline font-medium'
>
fund us on github.com.co
</a>
</p>

<p>
Issues?{' '}
<a
href='mailto:support@monkeys.com.co'
className='text-brand-orange hover:underline font-medium'
>
Contact us
</a>
</p>

<p className='text-[10px] text-foreground/40 mt-1'>
Works instantly on mobile or desktop and every browser
</p>
</div>
</div>
</div>
)}
)}
</div>
</div>

{activeError ? (
Expand All @@ -446,12 +464,7 @@ export const SnapshotStudio = ({
) : null}
</section>

<aside
className={cn(
'flex flex-col gap-5',
previewMode === 'x' ? 'lg:order-1' : ''
)}
>
<aside className={cn('flex flex-col gap-5')}>
{previewMode === 'template' ? (
<Accordion
type='multiple'
Expand Down
Loading