Skip to content

fix: blog share pill click target #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shubhashish-Chakraborty wants to merge 4 commits into
base: main
Choose a base branch
from
+13 −5
Open

fix: blog share pill click target #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
639b10a
fix: blog share pill click target
Shubhashish-Chakraborty Aug 20, 2026
af3717a
Merge branch 'main' into fix/share-pill-click-target
Shubhashish-Chakraborty Sep 3, 2026
62ee1ed
fixes
Shubhashish-Chakraborty Sep 3, 2026
8178e6e
fix
Shubhashish-Chakraborty Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions apps/the_monkeys/src/app/blog/components/BlogReactions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ export const BlogReactionsContainer = ({
<div className='flex-1 px-[14px] py-[6px] bg-foreground-light/80 dark:bg-foreground-dark/80 backdrop-blur-sm rounded-full shadow-sm ring-1 ring-border-light dark:ring-border-dark'>
<BlogReactions blogId={blogId} />
</div>

<div
className={twMerge(
'shrink-0 px-[10px] py-[6px] bg-alert-red/60 backdrop-blur-sm rounded-full shadow-sm ring-1 ring-alert-red',
Expand All @@ -76,9 +75,12 @@ export const BlogReactionsContainer = ({
>
{blogId && <BlogReportDialog size={24} blogId={blogId} />}
</div>

<div className='shrink-0 px-[10px] py-[6px] bg-foreground-light/80 dark:bg-foreground-dark/80 backdrop-blur-sm rounded-full shadow-sm ring-1 ring-border-light dark:ring-border-dark'>
<BlogShareDialog blogURL={url} size={20} />
<div className='shrink-0'>
<BlogShareDialog
blogURL={url}
size={20}
triggerClassName='px-[10px] py-[6px] bg-foreground-light/80 dark:bg-foreground-dark/80 backdrop-blur-sm rounded-full shadow-sm ring-1 ring-border-light dark:ring-border-dark hover:bg-foreground-light dark:hover:bg-foreground-dark hover:ring-brand-orange/50 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-brand-orange'

@Gautam7352 Gautam7352 Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this many tailwind properties here?

@Shubhashish-Chakraborty Shubhashish-Chakraborty Sep 3, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these classes are not required for the click functionality. They are needed only to preserve the existing pill appearance and add clearer hover/focus feedback.

So, the full list is not strictly required, but the padding, background, rounded shape, and hover/focus styles should remain to keep the intended design and UX.

SO what should i do with them lmk.
I feel it looks fine tho.

/>
</div>
</div>
);
Expand Down
8 changes: 7 additions & 1 deletion apps/the_monkeys/src/components/blog/actions/BlogShareDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,18 @@ import {
DialogTrigger,
} from '@the-monkeys/ui/atoms/dialog';
import { toast } from '@the-monkeys/ui/hooks/use-toast';
import { twMerge } from 'tailwind-merge';

@Gautam7352 Gautam7352 Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we import twmerge here?

@Shubhashish-Chakraborty Shubhashish-Chakraborty Sep 3, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the twMerge is used so the default button classes and the caller-provided triggerClassName can safely be combined. It resolves conflicting Tailwind utilities such as:

'p-1' and: 'px-[10px] py-[6px]'

Without twmerge, both classes may remain in the final class string, and the resulting styling can depend on Tailwind’s generated CSS order. twMerge ensures the custom trigger styles correctly override the defaults.


interface BlogShareDialogProps {
blogURL: string;
size?: number;
triggerClassName?: string;
}

export const BlogShareDialog: FC<BlogShareDialogProps> = ({
blogURL,
size = 18,
triggerClassName,
}) => {
const copyToClipboard = () => {
if (navigator.clipboard) {
Expand All @@ -49,7 +52,10 @@ export const BlogShareDialog: FC<BlogShareDialogProps> = ({
<Dialog>
<DialogTrigger asChild>
<button
className='p-1 flex items-center justify-center cursor-pointer opacity-80 hover:opacity-100'
className={twMerge(
'p-1 flex items-center justify-center cursor-pointer opacity-80 hover:opacity-100 transition-colors',
triggerClassName
)}
title='Share Blog'
>
<Icon name='RiShare' size={size} />
Expand Down