fuzz: make fuzz_rclient reach the rpcap packet-read path - #1692
Open
matejsmycka wants to merge 1 commit into
Open
fuzz: make fuzz_rclient reach the rpcap packet-read path#1692matejsmycka wants to merge 1 commit into
matejsmycka wants to merge 1 commit into
Conversation
Author
|
I think the failure is a CI/CD issue, not a PR issue. |
Member
If by "the failure" you mean the Appveyor failure, yeah, it's a CI/CD issue, the issue being "Appveyor has, for some unknown reason, immense difficulty opening some TLS connections in order to download tools or libraries". I've restarted the build, just for the lulz, but, unless the fuzzing code can be built and run on Windows, this change is unlikely to make anything worse on Windows. |
guyharris
reviewed
Jul 27, 2026
| while (r > 0) { | ||
| unsigned int i, sum = 0; | ||
| fprintf(outfile, "packet length=%d/%d\n",header->caplen, header->len); | ||
| for (i = 0; i < header->caplen; i++) |
Member
There was a problem hiding this comment.
This doesn't look as if it's related to this issue. Is that debugging code that leaked out into the pull request, or is it part of another change you want to submit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fuzz_rclient target never reached the rpcap packet-reading code because the fuzzing sock_open() stub returned INVALID_SOCKET and getpeername()/getnameinfo() failed on the unconnected fuzzing socket; this gives the stub a usable socket, skips those connection-dependent calls under the fuzzing macro, and has the harness read the captured bytes so sanitizers can catch over-reads.