Conversation
- Add VIA v3 keyboard definition for Royal Kludge R65 (VID: 0x342D, PID: 0xE481) - Include it in supported keyboards index - Improve response validation to handle firmware variations - Accept alternate response formats from keyboards with different firmware - Reduces false positives for 'Receiving incorrect response' errors Fixes: Keyboard definition loading errors and hardware communication issues
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Royal Kludge R65 keyboard (VID: 0x342D, PID: 0xE481) was causing errors in VIA due to:
Solution
Enhanced the keyboard API command handler to accept multiple response formats:
response[1]contains the command ID (new)This allows keyboards like the RK-R65 that implement firmware variations to work correctly while maintaining validation for truly malformed responses.
Changes
src/utils/keyboard-api.ts: Modified_hidCommand()method to validate responses more flexiblybuffer[1] === commandTesting
Verified with Royal Kludge R65:
Related
Users can now configure RK-R65 keyboards by sideloading the keyboard definition through VIA's Design tab.