Skip to content

fix: skip I9kModal showModal when the dialog left the page #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ismail9k merged 2 commits into from
Oct 26, 2026
Merged

fix: skip I9kModal showModal when the dialog left the page #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a67c62
fix: skip I9kModal showModal when the dialog left the page
posthog-eu[bot] Oct 14, 2026
03830f5
Merge origin/main into posthog-self-driving/fixi9kmodal-skip-showmoda…
ismail9k Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/I9kModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ function isShown(element: HTMLDialogElement) {

function show() {
const element = dialog.value;
if (unmounting || !element || isShown(element)) return;
// The dialog can also leave the document while the modal stays mounted (a
// removed subtree, a page cached by <KeepAlive>), and showModal() throws on a
// disconnected element.
if (unmounting || !element || !element.isConnected || isShown(element)) return;
// Kept when the dialog is shown again after the browser closed it, so focus
// still returns to the element that opened it, not to where focus landed.
if (!returnFocus) {
Expand Down
8 changes: 8 additions & 0 deletions tests/I9kModal.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,14 @@ describe('I9kModal with a native dialog', () => {
expect(document.activeElement).toBe(opener);
});

it('does not show a dialog that left the page before the queued show ran', async () => {
const wrapper = mountModal({ open: false });
(wrapper.get('dialog').element as HTMLDialogElement).remove();
await wrapper.setProps({ open: true });
await wrapper.vm.$nextTick();
expect(prototype.showModal).not.toHaveBeenCalled();
});

// A route change in an app: the old page stays mounted under <Suspense>
// while the next one loads, and re-rendering the modal then (here its
// `dismissible` coming back once a save ends) leaves Vue a ref update that
Expand Down
Loading