feat(web): fix card heights, drop the section heading, point the book block at the songbook - #136
Open
TheMaestr-o wants to merge 1 commit into
Open
feat(web): fix card heights, drop the section heading, point the book block at the songbook#136TheMaestr-o wants to merge 1 commit into
TheMaestr-o wants to merge 1 commit into
Conversation
TheMaestr-o
force-pushed
the
feat/home-grid-polish
branch
from
August 3, 2026 06:03
a299e60 to
2154f2d
Compare
…book block at the songbook Card heights become one number applied as a fixed height instead of a floor. min-height let a long verse push its card taller, and because the mobile columns are balanced by those heights (240 + 12 + 192 = 444 = 216 + 12 + 216) the two columns stopped ending level — 37px apart at 360px. It looked intermittent only because the verse rotates hourly and only the long ones did it, which is why an earlier attempt at this looked fixed and was not. Fixing the box exposed the other half: the fitter asked the CARD whether its content fit, and a fixed box reports its own clamped height at every size, so the first rung always passed while the text was clipped. It measures the card body's overflow now, and the ladder reaches 13px so the worst case in the pool — a 112-character verse in a 156px-wide card at 360px — still fits. The section heading is gone; the five cards carry it. HomeGridConfig drops eyebrow and title, the admin panel that edited them goes with it, and so do the message keys and the CSS. Block buttons take one-word labels and white-space: nowrap. A pill that wraps stops being a pill: the old multi-word labels broke over three lines inside the capsule at 360px and grew past the card edge. The book block becomes the songbook. It links to newsData.song.href, which already carried the songbook URL per environment, and shows only its label over the photo. The admin preview frames become real device sizes — 1280x900, 900x1180, 390x844. The mobile frame was 1900px tall, which is no phone that exists, and every vh rule on the page resolved against it, so the preview showed a layout nobody would ever get. The verse card's save-as-image button is temporarily behind a flag while the image it generates is still being designed. Columns verified level at 360/375/390/393/414/430/640/768/1280.
TheMaestr-o
force-pushed
the
feat/home-grid-polish
branch
from
August 3, 2026 06:12
2154f2d to
e25ccdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the card heights so the mobile columns stay level, drops the section heading, and points the book block at the songbook.
Base:
feat/home-grid-admin(#130) — merge that first. No issue of its own; this is follow-up work on #126 and #130 found while checking the pages live.The columns
Card heights become one number applied as a fixed
heightinstead of a floor. As amin-heighta long verse pushed its card taller, and because the mobile columns are balanced by those heights (240 + 12 + 192 = 444 = 216 + 12 + 216) the two columns stopped ending level — 37px apart at 360px. It looked intermittent only because the verse rotates hourly and only the long ones did it, which is why an earlier attempt looked fixed and was not.Fixing the box exposed the other half: the fitter asked the card whether its content fit, and a fixed box reports its own clamped height at every size, so the first rung always passed while the text was silently clipped. It measures the card body's overflow now, and the ladder reaches 13px so the worst case in the pool — a 112-character verse in a 156px-wide card at 360px — still fits.
The rest
HomeGridConfigdropseyebrowandtitle, and the admin panel that edited them goes with it.white-space: nowrap. A pill that wraps stops being a pill.newsData.song.href, which already carried the songbook URL per environment.vhrule resolved against it.Columns verified level at 360/375/390/393/414/430/640/768/1280, both locales, both themes.