Add API client generation and fix IsEditable bug#6
Open
RutgerDijk wants to merge 3 commits into
Open
Conversation
IPAccessEntry.IsEditable lacked the [Column] attribute, so NPoco (with [ExplicitColumns]) never sent it to the database on insert, causing a NOT NULL constraint violation. Also set IsEditable = true for new entries in the Save method.
- Add openapi-typescript-codegen and generate:api script - Regenerate TypeScript API client from current Swagger spec - Fix frontend type errors from updated IPAccessEntry model - Add client README (Dutch)
Contributor
|
Nice @RutgerDijk ! This will help us move on 👌 @JHHessels will you be able to merge this PR so we can use the API generation for upcoming PR's? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Column("IsEditable")]attribute onIPAccessEntry, which caused NOT NULL constraint failures when saving new IP entriesopenapi-typescript-codegentooling to regenerate the TypeScript API client from the backend Swagger spec (npm run generate:api)Test plan
npm run generate:apiwith the backend running — should regenerateclient/src/api/without errorsnpm run buildinclient/— should compile without type errors