Skip to content

React 19: replace defaultProps with es6 defaults #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackw wants to merge 2 commits into
base: master
Choose a base branch
from
Open

React 19: replace defaultProps with es6 defaults #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ad047b
refactor: use es6 defaults for react 19 compatibility
jackw Apr 27, 2026
bb5898e
chore(handleScroll): tidy some types
jackw Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/UI.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ const RemoveScroll: RemoveScrollUIType = React.forwardRef<HTMLElement, IRemoveSc
forwardProps,
children,
className,
removeScrollBar,
enabled,
removeScrollBar = true,
enabled = true,
shards,
sideCar,
noRelative,
noIsolation,
inert,
inert = false,
allowPinchZoom,
as: Container = 'div',
gapMode,
Expand Down Expand Up @@ -86,12 +86,6 @@ const RemoveScroll: RemoveScrollUIType = React.forwardRef<HTMLElement, IRemoveSc
);
}) as any;

RemoveScroll.defaultProps = {
enabled: true,
removeScrollBar: true,
inert: false,
};

RemoveScroll.classNames = {
fullWidth: fullWidthClassName,
zeroRight: zeroRightClassName,
Expand Down
4 changes: 2 additions & 2 deletions src/handleScroll.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ const getDirectionFactor = (axis: Axis, direction: string | null) =>
export const handleScroll = (
axis: Axis,
endTarget: HTMLElement,
event: any,
event: WheelEvent | TouchEvent,
sourceDelta: number,
noOverscroll: boolean
) => {
): boolean => {
const directionFactor = getDirectionFactor(axis, window.getComputedStyle(endTarget).direction);
const delta = directionFactor * sourceDelta;

Expand Down