Repository navigation
Conversation
Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
✅ Deploy Preview for theagentrouter ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
|
/retest |
nacx
marked this pull request as ready for review
October 5, 2026 15:30
mathetake
approved these changes
Oct 5, 2026
Member
Author
|
/retest |
Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
Member
Author
|
/retest |
This was referenced Oct 6, 2026
nacx
pushed a commit
that referenced
this pull request
Oct 6, 2026
…#2794) **Description** `TestRunExtprocStartFailure` has been flaky on both ubuntu and macOS since the Envoy Gateway v1.9.2 bump (#2787). It fails with "expected extproc start to fail promptly" after its 10s timeout, on main and on PRs alike. When the extproc fails, `run` cancels the Envoy Gateway server's context and returns once `server.ExecuteContext` returns. Since v1.9.2, EG's shutdown waits for every runner goroutine to exit [1][2]. That includes the file provider's `Start`, which runs the initial load of the resources even when the context was canceled before it began. With v1.9.0 nothing waited for it. With the CI flags (`-race`, atomic coverage), pinned to 4 cores, the time from the cancel to `ExecuteContext` returning in this test went from 0.15s to 3.12s (median of 10 runs). The wait is mostly single-threaded, and on CI runners, which run several test packages at once, it often goes past 10s. Running the test on one core shared with two busy loops reproduces the failure on main (10.01s). With this change it passes (12.01s). The timeout only needs to catch `run` hanging after the extproc fails, which is what #1134 fixed. This raises it to 60s and adds a comment explaining why. **Related Issues/PRs (if applicable)** Fixes #2793 **Special notes for reviewers (if applicable)** Making `run` itself return faster would need EG to skip the initial load once the context is canceled, which is an upstream change. 1: https://github.com/envoyproxy/gateway/blob/v1.9.2/release-notes/v1.9.2.yaml 2: envoyproxy/gateway#10128 Signed-off-by: Abdulaziz Alharbi <246710009+abdulaziz-dev-lab@users.noreply.github.com> Co-authored-by: Abdulaziz Alharbi <246710009+abdulaziz-dev-lab@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump EG dependency to
v1.9.2Related Issues/PRs (if applicable)
Release notes PR: #2786
Special notes for reviewers (if applicable)
N/A