Repository navigation
Conversation
The aigw cross-namespace Secret fixture and the connect-providers docs example left out to.name, which grants every Secret in the namespace. Signed-off-by: Abdulaziz Alharbi <246710009+abdulaziz-dev-lab@users.noreply.github.com>
✅ Deploy Preview for theagentrouter canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
aabchoo
approved these changes
Oct 7, 2026
missBerg
added
documentation
aabchoo
enabled auto-merge (squash)
October 9, 2026 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ReferenceGrant examples for a BackendSecurityPolicy whose Secret is in another namespace leave out
to.name, so each one allows every Secret in that namespace. This names the one Secret each example needs:cmd/aigw/testdata/cross_namespace_secret_grant.yamlnow grants onlyshared-openai-apikey, soTestRunCmdContext_writeEnvoyResourcesAndRunExtProc_crossNamespaceSecretruns with a grant scoped to the Secret.namedoes and how to allow more than one Secret.Related Issues/PRs (if applicable)
Follow-up to #2783, for @aabchoo's review comment [1].
Special notes for reviewers (if applicable)
The example in the v1.2 upgrade guidance already names the Secret, so the release notes are unchanged.
1: #2783 (comment)