Repository navigation
fix: avoid charging request-time quota hit - #2816
Open
PatilHrushikesh wants to merge 5 commits into
Open
PatilHrushikesh wants to merge 5 commits into
PatilHrushikesh wants to merge 5 commits into
Conversation
Signed-off-by: Hrushikesh Patil <hrushi2900@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for theagentrouter canceled.
|
PatilHrushikesh
marked this pull request as ready for review
October 8, 2026 10:10
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Hrushikesh Patil <hrushi2900@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
AyushSawant18588
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes token quota accounting for request-time rate-limit checks.
Previously, QuotaPolicy request-time rate-limit entries omitted
hits_addend. Envoy Rate Limit Service treats an omitted value as an increment of1, so a completed request withtotal_tokens = 28charged1at request time and28again when the response completed, resulting in29tokens deducted.This change:
hits_addendof0inbuildSimpleModelEntries.buildBucketRuleLimitEntries.quota_costmetadata, which charges the actual token usage.Validation
go test -count=1 ./internal/extensionservergo test -count=1 ./internal/controller ./internal/extensionservertotal_tokens = 28, request-timehits_addend = 0, stream-donehits_addend = 28, and an RLS cache increment of exactly28.Special notes for reviewers
BackendTrafficPolicy is not changed by this PR. Its token-cost configuration already supports an explicit request cost of
0and a response cost from AI Gateway dynamic metadata. Ordinary request-count BackendTrafficPolicy limits continue to use their intended request increment.