WPD-207: Replace URLs for vimeo and youtube pages with the related em…#921
Open
WPD-207: Replace URLs for vimeo and youtube pages with the related em…#921
Conversation
bdsl
force-pushed
the
WPD-207-embed-url
branch
2 times, most recently
from
de3dfb9 to
b5c6da1
Compare
|
Vimeo tests feel a bit repetitive with only the title differing. Probably worth using 'it.each' to reduce duplication? |
…nstead of repeating test code
Contributor
Author
Very fair point - I've refactored to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…bed iframe URLS