Refine chat keyboard focus and IME scrolling - #46
Open
zcmx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behavior
This PR intentionally proposes a UX behavior change rather than treating the previous behavior as objectively incorrect. Some users may prefer the existing behavior where the composer opens automatically whenever a chat becomes active. The proposed policy is:
Maintainers may prefer to keep the old policy or make this configurable; feedback on the behavior itself is welcome.
Problem
On phones, opening an existing chat could immediately show the keyboard and consume much of the viewport. Conversely, when the user opened the keyboard intentionally, the newest messages could remain off-screen or be covered during IME resize.
Changes
focusInputchat navigation argument with a safe default offalse.focusInput=trueonly for newly created sessions.Verification
ChatScrollRestorationTestandScreenChatRouteTestpass on the integrated branch.git diff --checkpasses.The clean
mainbranch currently blocks local Android unit-test compilation becausecompileDebugJavaWithJavactargets JVM 17 whilecompileDebugKotlintargets JVM 21. The same targeted tests passed before extracting this commit onto the clean PR branch.