Fix QKMS async CreateKey and timeout behavior - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
CreateKey?async=1support to match the official Quilibrium QKMS SDK/sample and avoid long-lived MPC/DKG requests being killed by proxy/CDN timeouts.Content-Type: application/json.CreateKeycalls non-idempotent so timeout/5xx handling cannot automatically retry and create duplicate key tasks.1.1.0->1.2.0) exposed by the full test run.Verification
Clean GNU 16.2 / C++23 / Ninja build with warnings-as-errors completed successfully.
ctest --test-dir build-qkms-clean --output-on-failure:quilibrium_facade_testspassedquilibrium_service_testspassedquilibrium_c_api_testspassedgit diff --checkcleanScope note
This fixes the SDK-side HTTP/timeout behavior. It intentionally does not reimplement the browser/server participant-side MPC ceremony; that layer belongs to Quilibrium's official
qkms-sdk. If an async CreateKey task is accepted but theserviceparticipant still fails to advance/complete its ceremony task, that is an upstream QKMS/server-side issue rather than this SDK's HTTP wrapper.