Skip to content

feat: 4.1.0 pr-review improvements #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedoublejay merged 5 commits into from
May 13, 2026
Merged

feat: 4.1.0 pr-review improvements #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6896ac
feat: add pr-review PR-set manifest schema
thedoublejay May 13, 2026
33fd4d7
feat: add multi-pr review sets
thedoublejay May 13, 2026
83737d5
docs: prepare 4.1.0 pr-review docs
thedoublejay May 13, 2026
b33593a
fix: satisfy multi-pr clippy lint
thedoublejay May 13, 2026
bdf91ef
fix: address pr-review set review findings
thedoublejay May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/gather-step-cli/src/commands/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,26 @@ mod tests {
}
}

#[test]
fn rejects_zero_pr_review_parallelism_during_parse() {
let error = Cli::try_parse_from([
"gather-step",
"pr-review",
"--pr-set",
"examples/pr-set/cross-repo-feature.yaml",
"--parallelism",
"0",
])
.expect_err("zero parallelism should be rejected by clap");

assert!(
error
.to_string()
.contains("--parallelism must be an integer greater than or equal to 1"),
"unexpected error for zero parallelism: {error}"
);
}

#[test]
fn parses_top_level_serve_args() {
let cli = Cli::parse_from([
Expand Down
Loading