Parameter type normalization#1663
Draft
evgeni wants to merge 3 commits into
Draft
Conversation
We define the `value` attribute as `raw` as it can have different data types, which means Ansible will helpfully convert a `"['something']"` string to an actual array with the entry `'something'`. However, if the `parameter_type` in Foreman is `string`, we really should send a string, not an array Ansible converted for us.
evgeni
force-pushed
the
parameter-type-normalization
branch
from
90e9ab0 to
f4bea7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #1659 we realized that even tho the user might pass
'["something"]'as a string to Ansible, our code will receive["something"]as an array later, which might have weird consequences when passing the data to Foreman.This is an attempt to fix it.