Skip to content

LDAP RFC4519 group membership#1868

Merged
evgeni merged 2 commits into
theforeman:developfrom
adamruzicka:ldap-rfc4519
Jul 22, 2025
Merged

LDAP RFC4519 group membership#1868
evgeni merged 2 commits into
theforeman:developfrom
adamruzicka:ldap-rfc4519

Conversation

@adamruzicka
Copy link
Copy Markdown
Contributor

Companion to theforeman/foreman#10527 . Draft until the main PR settles

Comment thread plugins/modules/auth_source_ldap.py Outdated
Comment thread plugins/modules/auth_source_ldap.py
@adamruzicka adamruzicka force-pushed the ldap-rfc4519 branch 5 times, most recently from 1dd5687 to a311284 Compare July 2, 2025 12:48
@adamruzicka adamruzicka force-pushed the ldap-rfc4519 branch 2 times, most recently from 0f56dca to f6325c4 Compare July 15, 2025 16:23
@adamruzicka adamruzicka marked this pull request as ready for review July 15, 2025 16:35
@adamruzicka
Copy link
Copy Markdown
Contributor Author

🟢

@adamruzicka adamruzicka requested a review from evgeni July 17, 2025 08:20
Comment thread plugins/modules/auth_source_ldap.py Outdated
Copy link
Copy Markdown
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack with a styling nitpick :)

@evgeni
Copy link
Copy Markdown
Member

evgeni commented Jul 22, 2025

argh, line too long what

ldap_group_membership (LGM) wins over use_netgroups, if both are passed
in. If LGM is unsupported by the server, user-provided use_netgroups is
used. If LGM is unsupported by the server, but no use_netgroups is
provided by the user, use_netgroups is derived from LGM.
@adamruzicka
Copy link
Copy Markdown
Contributor Author

Whoops, might have accidentally overwritten your changes

@evgeni evgeni merged commit f153f89 into theforeman:develop Jul 22, 2025
61 of 84 checks passed
@adamruzicka adamruzicka deleted the ldap-rfc4519 branch July 22, 2025 14:56
@evgeni evgeni mentioned this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants